Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several flake8 warnings & Update .flake8 #38

Closed
wants to merge 1 commit into from
Closed

Fix several flake8 warnings & Update .flake8 #38

wants to merge 1 commit into from

Conversation

drLite35
Copy link

This closes #16.

  • Updated .flake8 with latest pep8 guidelines regarding operator break.
  • Fixed all the flake8.

Kindly review @walterbender @chimosky @quozl .

@chimosky
Copy link
Member

Running flake8 shows ./juego.py:404:17: F821 undefined name 'game_over' and rightly so as game_over exists in play so you'll have to change that.

@drLite35
Copy link
Author

Changed that!
Thanks

@chimosky
Copy link
Member

chimosky commented May 4, 2024

Tested 98f44a4, it'll be great to not change the position of game_over and just change the indentation.

With your change, the activity starts and after the play button is clicked, the activity canvas still shows the same screen and the sound plays to tell you the game has started and after a number of failures you see the game over screen.

Nothing in the log show clearly why, but the log shows this;

1714811501.291445 ERROR root: Key AudioPrev unrecognized
1714811501.398156 ERROR root: Key AudioPrev unrecognized
1714811501.688593 ERROR root: Key AudioPlay unrecognized
1714811501.788952 ERROR root: Key AudioPlay unrecognized

@drLite35
Copy link
Author

drLite35 commented May 4, 2024

Yes, its generating errors.

@drLite35 drLite35 closed this May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake8 opportunities
2 participants