Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meterWidget: fix sound playing indefinitely on reload and enhancement to fullscreen mode #2771

Merged

Conversation

ksraj123
Copy link
Member

@ksraj123 ksraj123 commented Jan 24, 2021

This PR does the following

  • fixes sound playing indefinitely bug when reloaded while playing
  • enhances fullscreen mode for this widget
  • adds jsDoc style documentation
  • fixes linting issues
  • prettifies code

Related Issues #2767, #2630, #2609

Bug Details

When the sound is playing and the widget is reloaded with new settings then the widget reloads but the sound does not stop playing and it plays indefinitely. Even closing the widget does not stop it. The ideal behaviour should be that the sound should stop playing when the widget is reloaded.

Please keep audio on while playing the video below to notice the bug.

meter_bug.mov

Enhancement Details

Fullscreen mode does nothing, the extra space in fullscreen mode is not utilised in a meaningful way.

meter_fullscreen_before

After Changes

  • Sound playing indefinitely on reload while playing bug fixed. Upon reloading the sound stops if playing.

Please keep audio on while playing the video below to notice the changes.

meter_bug_after.mov
  • Full screen mode enhanced

meter_fullscreen_after

Copy link
Member

@meganindya meganindya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However, something seems to be off with the save action. The action block doesn't get generated on my end. Pls verify.

@ksraj123
Copy link
Member Author

@meganindya save seems to be working fine. I guess the action blocks are not meant to be generated but are to specify some action to be performed (similar functionality in master too).
Here's a short walkthrough of my testing

meter_save_working_fine.mov

@meganindya
Copy link
Member

Oh! You're right. Absolutely rolled off my mind :D

@meganindya meganindya merged commit 2462d31 into sugarlabs:master Jan 26, 2021
@ksraj123 ksraj123 changed the title BugFix and Enhancement: widgets/meterWidget meterWidget: fix sound playing indefinitely on reload and enhancement to fullscreen mode Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants