meterWidget: fix sound playing indefinitely on reload and enhancement to fullscreen mode #2771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following
Related Issues #2767, #2630, #2609
Bug Details
When the sound is playing and the widget is reloaded with new settings then the widget reloads but the sound does not stop playing and it plays indefinitely. Even closing the widget does not stop it. The ideal behaviour should be that the sound should stop playing when the widget is reloaded.
Please keep audio on while playing the video below to notice the bug.
meter_bug.mov
Enhancement Details
Fullscreen mode does nothing, the extra space in fullscreen mode is not utilised in a meaningful way.
After Changes
Please keep audio on while playing the video below to notice the changes.
meter_bug_after.mov