Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made jest file for munsell.js #4132

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

Commanderk3
Copy link
Contributor

@Commanderk3 Commanderk3 commented Dec 12, 2024

Issue #4124

I am creating a new PR. The package-lock-json file somehow got changed, i dont know how. But this should work. @walterbender
This PR addresses the need of a jest testing file for munsell.js
It validates the functionality of four core functions from the Munsell module: interpColor, getMunsellColor, getcolor, and searchColors.

image

@walterbender walterbender merged commit 86872af into sugarlabs:master Dec 12, 2024
4 checks passed
@apsinghdev
Copy link
Member

@walterbender I guess @Commanderk3 has mistakenly removed the jest dependency from the package.json file. This results in other contributors not having jest in their local development environment to run tests.

Screenshot 2024-12-14 at 11 40 24 PM

@walterbender
Copy link
Member

please write up an issue.

@Commanderk3
Copy link
Contributor Author

I checked the history of package.json
I don't think I changed it.

@apsinghdev
Copy link
Member

Member

done. fixing it.

@apsinghdev
Copy link
Member

I checked the history of package.json I don't think I changed it.

have you checked devDependencies of package.json?

@Commanderk3
Copy link
Contributor Author

Yes it shows everything

@apsinghdev
Copy link
Member

Yes it shows everything

does it contain jest? I've pulled the latest changes from the upstream but jest is not there?

Screenshot 2024-12-14 at 11 40 24 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants