2016 RLX attempt 1

[thirdstick]

2016 RLX attempt 1

Summary by Sourcery

New Features:

• Initial support for the 2016 Acura RLX, including fingerprinting, values, and DBC data.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request adds support for the 2016 Acura RLX.

Entity relationship diagram for ECU fingerprints

erDiagram
    ACURA_RLX ||--o{ ECU : contains
    ECU {
        string vsa
        string fwdRadar
        string srs
    }
    ECU ||--o{ FIRMWARE : has
    FIRMWARE {
        string version
    }

    note "New ECU fingerprints added for Acura RLX"

Loading

Class diagram for the updated Honda car configuration

classDiagram
    class CAR {
        +ACURA_RLX: HondaNidecPlatformConfig
    }

    class HondaNidecPlatformConfig {
        +CarDocs[]
        +CarSpecs
        +radar_dbc_dict
        +flags
    }

    class ACURA_RLX_Config {
        +mass: 1836.0 LB_TO_KG
        +wheelbase: 2.70
        +steerRatio: 13.0
        +centerToFrontRatio: 0.3794
        +tireStiffnessFactor: 0.444
        +min_steer_speed: 0 MPH_TO_MS
    }

    CAR --> HondaNidecPlatformConfig
    ACURA_RLX_Config --> HondaNidecPlatformConfig

    note for ACURA_RLX_Config "New configuration added for 2016 Acura RLX"

Loading

File-Level Changes

Change	Details	Files
Added fingerprint data for the 2016 Acura RLX.	Added fingerprints for the VSA, FwdRadar, and SRS ECUs for the 2016 Acura RLX.	opendbc/car/honda/fingerprints.py
Added platform configuration for the 2016 Acura RLX.	Added CAR.ACURA_RLX to the CAR enum. Defined car specifications and radar DBC dictionary for the 2016 Acura RLX, reusing the configuration from the 2016-2018 Acura RDX.	opendbc/car/honda/values.py
No changes to the Acura RDX 2018 CAN DBC file were made in this pull request.		opendbc/dbc/generator/honda/acura_rdx_2018_can.dbc

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @thirdstick - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please improve the PR title and description to explain what changes are being made and why. Include information about any testing performed.
• The vehicle parameters (mass, wheelbase, steerRatio, etc.) appear to be copied from the RDX. Please verify these against actual 2016 RLX specifications.
• Using the RDX's DBC file for the RLX needs justification. Are you certain the CAN messages are identical between these different models?

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (bug_risk): The car model in HondaCarDocs appears to be incorrect - this should be for RLX, not RDX

This could cause confusion about which vehicle models are supported and might lead to compatibility issues.