-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix executable node/mjml-cli path checks
A regression in 00db9a9 broke setups that depended on PATH environment variables to execute the given node and MJML CLI binaries (`MJML_NODE_PATH` and `MJML_CLI_PATH` environment configurations). Various combinations with `npx`, `nvm`, `pnpm dlx` broke. This commit introduces a more intelligent check using `is_executable` and all PATH environment prefixes that should guarantee that an executable will still still be found. A convenient wrapper has been introduced via `MJMLService::isExecutable`. Fixes #26
- Loading branch information
1 parent
259a1ae
commit 343fbd2
Showing
1 changed file
with
43 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters