Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement readOnly property for survey #6291

Merged
merged 5 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions packages/survey-core/src/survey.ts
Original file line number Diff line number Diff line change
Expand Up @@ -978,8 +978,8 @@ export class SurveyModel extends SurveyElementCore
this.registerPropertyChangedHandlers(["firstPageIsStartPage"], () => {
this.onFirstPageIsStartedChanged();
});
this.registerPropertyChangedHandlers(["mode"], () => {
this.onModeChanged();
this.registerPropertyChangedHandlers(["readOnly"], () => {
this.onReadOnlyChanged();
});
this.registerPropertyChangedHandlers(["progressBarType"], () => {
this.updateProgressText();
Expand All @@ -991,7 +991,7 @@ export class SurveyModel extends SurveyElementCore
}
);
this.registerPropertyChangedHandlers(
["isLoading", "isCompleted", "isCompletedBefore", "mode", "isStartedState", "currentPage", "isShowingPreview"],
["isLoading", "isCompleted", "isCompletedBefore", "readOnly", "isStartedState", "currentPage", "isShowingPreview"],
() => { this.updateState(); });
this.registerPropertyChangedHandlers(["state", "currentPage", "showPreviewBeforeComplete"],
() => { this.onStateAndCurrentPageChanged(); });
Expand Down Expand Up @@ -3110,15 +3110,22 @@ export class SurveyModel extends SurveyElementCore
* [View Demo](https://surveyjs.io/form-library/examples/survey-displaymode/ (linkStyle))
*/
public get mode(): string {
return this.getPropertyValue("mode");
return this.readOnly ? "display" : "edit";
}
public set mode(value: string) {
value = value.toLowerCase();
if (value == this.mode) return;
if (value != "edit" && value != "display") return;
this.setPropertyValue("mode", value);
this.readOnly = value == "display";
}
private onModeChanged() {
public get readOnly(): boolean {
return this.getPropertyValue("readOnly");
}
public set readOnly(val: boolean) {
this.setPropertyValue("readOnly", val);
}

private onReadOnlyChanged() {
for (var i = 0; i < this.pages.length; i++) {
var page = this.pages[i];
page.setPropertyValue("isReadOnly", page.isReadOnly);
Expand Down Expand Up @@ -3945,10 +3952,10 @@ export class SurveyModel extends SurveyElementCore
return res == "both" || res == "topBottom" || res == buttonPosition;
}
public get isEditMode(): boolean {
return this.mode == "edit";
return !this.readOnly;
}
public get isDisplayMode(): boolean { //
return this.mode == "display" && !this.isDesignMode || this.state == "preview";
return this.readOnly && !this.isDesignMode || this.state == "preview";
}
public get isUpdateValueTextOnTyping(): boolean {
return this.textUpdateMode == "onTyping";
Expand Down Expand Up @@ -5191,7 +5198,7 @@ export class SurveyModel extends SurveyElementCore
.append(this.css.rootProgress + "--" + this.progressBarType)
.append(this.css.rootMobile, this.isMobile)
.append(this.css.rootAnimationDisabled, !settings.animationEnabled)
.append(this.css.rootReadOnly, this.mode === "display" && !this.isDesignMode)
.append(this.css.rootReadOnly, this.readOnly && !this.isDesignMode)
.append(this.css.rootCompact, this.isCompact)
.append(this.css.rootFitToContainer, this.fitToContainer)
.toString();
Expand Down Expand Up @@ -8484,7 +8491,8 @@ Serializer.addClass("survey", [
dependsOn: ["showTOC"],
visibleIf: (survey: any) => { return !!survey && survey.showTOC; }
},
{ name: "mode", default: "edit", choices: ["edit", "display"] },
{ name: "readOnly:boolean", default: false },
{ name: "mode", default: "edit", choices: ["edit", "display"], visible: false },
{ name: "storeOthersAsComment:boolean", default: true },
{ name: "maxTextLength:number", default: 0, minValue: 0 },
{ name: "maxCommentLength:number", default: 0, minValue: 0, alternativeName: "maxOthersLength" },
Expand Down
28 changes: 28 additions & 0 deletions packages/survey-core/tests/surveytests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18744,6 +18744,34 @@ QUnit.test("Do not run onComplete twice if complete trigger and tryComplete() is
survey.tryComplete();
assert.equal(counter, 1, "onComplete called one time");
});

QUnit.test("Check readOnly flag", function (assert) {
let survey = new SurveyModel({
readOnly: true,
"elements": [
{
"type": "text",
"name": "question1"
},
],
});
assert.equal(survey.mode, "display");
assert.ok(survey.readOnly);
survey.readOnly = false;
assert.notOk(survey.readOnly);
survey = new SurveyModel({
mode: "display",
"elements": [
{
"type": "text",
"name": "question1"
},
],
});
assert.ok(survey.readOnly);
survey.mode = "edit";
assert.notOk(survey.readOnly);
});
QUnit.test("Expression with dates & defaultValueExpression & expression question", function (assert) {
const survey = new SurveyModel({
elements: [
Expand Down
Loading