dont upload output to s3

sushant12 · Oct 29, 2024 · 19e93c0 · 19e93c0
1 parent ae239ec
commit 19e93c0
Show file tree

Hide file tree

Showing 2 changed files with 62 additions and 64 deletions.
diff --git a/lib/handin/assignment_submission_server.ex b/lib/handin/assignment_submission_server.ex
@@ -184,7 +184,6 @@ defmodule Handin.AssignmentSubmissionServer do
   defp build_all_scripts(state) do
     build_main_script(state.assignment) ++
       build_file_download_script(state.assignment, state.user_id) ++
-      build_upload_script(state.assignment, state) ++
       build_check_script(state.assignment) ++
       build_tests_scripts(state.assignment)
   end
@@ -386,37 +385,37 @@ defmodule Handin.AssignmentSubmissionServer do
     ]
   end
 
-  defp build_upload_script(assignment, state) do
-    config = ExAws.Config.new(:s3, Application.get_all_env(:ex_aws))
-
-    template = """
-    #!/bin/bash
-    """
-
-    curls =
-      assignment.assignment_tests
-      |> Enum.map(fn assignment_test ->
-        {:ok, presigned_url} =
-          ExAws.S3.presigned_url(
-            config,
-            :put,
-            "handin-dev",
-            "uploads/assignments/#{assignment.id}/users/#{state.user_id}/submission/#{assignment_test.id}.out",
-            expires_in: 6000
-          )
-
-        "curl --request PUT --upload-file \"#{assignment_test.id}.out\" \"#{presigned_url}\""
-      end)
-
-    template = template <> Enum.join(curls, "\n")
-
-    [
-      %{
-        "guest_path" => "/upload.sh",
-        "raw_value" => Base.encode64(template)
-      }
-    ]
-  end
+  # defp build_upload_script(assignment, state) do
+  #   config = ExAws.Config.new(:s3, Application.get_all_env(:ex_aws))
+
+  #   template = """
+  #   #!/bin/bash
+  #   """
+
+  #   curls =
+  #     assignment.assignment_tests
+  #     |> Enum.map(fn assignment_test ->
+  #       {:ok, presigned_url} =
+  #         ExAws.S3.presigned_url(
+  #           config,
+  #           :put,
+  #           "handin-dev",
+  #           "uploads/assignments/#{assignment.id}/users/#{state.user_id}/submission/#{assignment_test.id}.out",
+  #           expires_in: 6000
+  #         )
+
+  #       "curl --request PUT --upload-file \"#{assignment_test.id}.out\" \"#{presigned_url}\""
+  #     end)
+
+  #   template = template <> Enum.join(curls, "\n")
+
+  #   [
+  #     %{
+  #       "guest_path" => "/upload.sh",
+  #       "raw_value" => Base.encode64(template)
+  #     }
+  #   ]
+  # end
 
   defp build_tests_scripts(assignment) do
     assignment.assignment_tests

diff --git a/lib/handin/build_server.ex b/lib/handin/build_server.ex
@@ -183,7 +183,6 @@ defmodule Handin.BuildServer do
   defp build_all_scripts(state) do
     build_main_script(state.assignment) ++
       build_file_download_script(state.assignment) ++
-      build_upload_script(state.assignment, state) ++
       build_check_script(state.assignment) ++
       build_tests_scripts(state.assignment)
   end
@@ -369,37 +368,37 @@ defmodule Handin.BuildServer do
     ]
   end
 
-  defp build_upload_script(assignment, state) do
-    config = ExAws.Config.new(:s3, Application.get_all_env(:ex_aws))
-
-    template = """
-    #!/bin/bash
-    """
-
-    curls =
-      assignment.assignment_tests
-      |> Enum.map(fn assignment_test ->
-        {:ok, presigned_url} =
-          ExAws.S3.presigned_url(
-            config,
-            :put,
-            "handin-dev",
-            "uploads/assignments/#{assignment.id}/users/#{state.user_id}/submission/#{assignment_test.id}.out",
-            expires_in: 6000
-          )
-
-        "curl --request PUT --upload-file \"#{assignment_test.id}.out\" \"#{presigned_url}\""
-      end)
-
-    template = template <> Enum.join(curls, "\n")
-
-    [
-      %{
-        "guest_path" => "/upload.sh",
-        "raw_value" => Base.encode64(template)
-      }
-    ]
-  end
+  # defp build_upload_script(assignment, state) do
+  #   config = ExAws.Config.new(:s3, Application.get_all_env(:ex_aws))
+
+  #   template = """
+  #   #!/bin/bash
+  #   """
+
+  #   curls =
+  #     assignment.assignment_tests
+  #     |> Enum.map(fn assignment_test ->
+  #       {:ok, presigned_url} =
+  #         ExAws.S3.presigned_url(
+  #           config,
+  #           :put,
+  #           "handin-dev",
+  #           "uploads/assignments/#{assignment.id}/users/#{state.user_id}/submission/#{assignment_test.id}.out",
+  #           expires_in: 6000
+  #         )
+
+  #       "curl --request PUT --upload-file \"#{assignment_test.id}.out\" \"#{presigned_url}\""
+  #     end)
+
+  #   template = template <> Enum.join(curls, "\n")
+
+  #   [
+  #     %{
+  #       "guest_path" => "/upload.sh",
+  #       "raw_value" => Base.encode64(template)
+  #     }
+  #   ]
+  # end
 
   defp build_tests_scripts(assignment) do
     assignment.assignment_tests