Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform instructors about potential syntax error #1069

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

fiveop
Copy link
Contributor

@fiveop fiveop commented Oct 13, 2023

We ran into the problem described in the proposed instructor note when we taught based on the course material recently.

It should be in front of the first example that potentially causes the error.

@github-actions
Copy link

github-actions bot commented Oct 13, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/python-novice-inflammation/compare/md-outputs..md-outputs-PR-1069

The following changes were observed in the rendered markdown documents:

 02-numpy.md                                    |  16 ++--------------
 03-matplotlib.md                               |   4 ++--
 04-lists.md                                    |   2 +-
 06-files.md                                    |  10 +++++-----
 07-cond.md                                     |   9 +++++++++
 08-func.md                                     |   6 +++---
 10-defensive.md                                |   4 ++--
 12-cmdline.md                                  |  12 ++++++------
 files/code/python-novice-inflammation-code.zip | Bin 7301 -> 7268 bytes
 files/code/readings_05.py                      |   2 +-
 md5sum.txt                                     |  16 ++++++++--------
 11 files changed, 39 insertions(+), 42 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-11-12 07:15:16 +0000

Copy link
Member

@ineelhere ineelhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @fiveop 🚀
Best wishes!

github-actions bot pushed a commit that referenced this pull request Nov 12, 2023
@ineelhere ineelhere merged commit 082631c into swcarpentry:main Nov 12, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 12, 2023
Auto-generated via {sandpaper}
Source  : 082631c
Branch  : main
Author  : Indraneel Chakraborty <[email protected]>
Time    : 2023-11-12 07:19:06 +0000
Message : Merge pull request #1069 from fiveop/syntax_error_multiple_statements

Inform instructors about potential syntax error
github-actions bot pushed a commit that referenced this pull request Nov 12, 2023
Auto-generated via {sandpaper}
Source  : 65f2d9e
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-11-12 07:20:33 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 082631c
Branch  : main
Author  : Indraneel Chakraborty <[email protected]>
Time    : 2023-11-12 07:19:06 +0000
Message : Merge pull request #1069 from fiveop/syntax_error_multiple_statements

Inform instructors about potential syntax error
github-actions bot pushed a commit that referenced this pull request Nov 14, 2023
Auto-generated via {sandpaper}
Source  : 65f2d9e
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-11-12 07:20:33 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 082631c
Branch  : main
Author  : Indraneel Chakraborty <[email protected]>
Time    : 2023-11-12 07:19:06 +0000
Message : Merge pull request #1069 from fiveop/syntax_error_multiple_statements

Inform instructors about potential syntax error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants