-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump node.js version to 18.17.0 [AP-1081] #1392
Conversation
9884314
to
d939d49
Compare
Quality Gate passed for 'libsbp-c'Kudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the patch numbers got all goofed. I will try and fix them from you but i don't want to merge it as is.
Please do, I spent most of last night trying to do this and gave up. The generator seems to come up with different values when run in CI versus locally. The state of this PR is just what gets through the check |
the issue is probably that the 5.0.4 tag is on an detached branch... maybe it's better to just have a commit that we take before the release which gets the version numbers aligned. I also recommend you add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming plan here, since v5.0.4 is on a non master branch we will take this commit back to 5.0.3 and then jump ahead to 5.0.5 next release so no tags are clobbered
Description
@swift-nav/devinfra
Bump node.js version in docker image to 18.17.0
This resolves the docker image build failures seen on #1373 and allows a freshly built docker image to build the javascript bindings
API compatibility
Does this change introduce a API compatibility risk?
No
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
N/A
JIRA Reference
https://swift-nav.atlassian.net/browse/AP-1081