Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aptos: add to pool (WIP) #460

Merged
merged 12 commits into from
Oct 26, 2022
Merged

Aptos: add to pool (WIP) #460

merged 12 commits into from
Oct 26, 2022

Conversation

nicomiicro
Copy link
Contributor

@nicomiicro nicomiicro commented Oct 25, 2022 •
edited
Loading

Adds PoolState aptos implementation

Notion ticket: https://www.notion.so/exsphere/Aptos-integration-f6daa06ac05b48f490528c38a50ffd88

Checklist

  • Github project and label have been assigned
  • Tests have been added or are unnecessary
  • Docs have been updated or are unnecessary
  • Preview deployment works (visit the Cloudflare preview URL)
  • Manual testing in #product-testing completed or unnecessary
  • New i18n strings do not contain any security vulnerabilities (e.g. should not allow translator to update email/url)
  • When fetching new translations from external sources, do a sanity check (e.g. get people who speak the language to check, shove all new translations into Google translate)

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 25, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c7156f1
Status: ✅  Deploy successful!
Preview URL: https://31eeea3c.swim-ui.pages.dev
Branch Preview URL: https://aptos-add-to-pool.swim-ui.pages.dev

View logs

wormat
wormat reviewed Oct 25, 2022
View reviewed changes
packages/solana/src/client.ts Show resolved Hide resolved
packages/aptos/src/protocol.ts Outdated Show resolved Hide resolved
packages/aptos/src/client.ts Outdated Show resolved Hide resolved
packages/aptos/src/client.ts Outdated Show resolved Hide resolved
packages/aptos/src/client.ts Outdated Show resolved Hide resolved
packages/aptos/src/client.ts Outdated Show resolved Hide resolved
packages/aptos/src/client.ts Show resolved Hide resolved
packages/aptos/src/client.ts Show resolved Hide resolved
packages/aptos/src/client.ts Outdated Show resolved Hide resolved
apps/ui/src/models/swim/pool.ts Show resolved Hide resolved
wormat
wormat reviewed Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@wormat wormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits.

packages/aptos/src/liquidswap/index.ts Outdated Show resolved Hide resolved
packages/aptos/src/liquidswap/utils.ts Outdated Show resolved Hide resolved
@nicomiicro
Copy link
Contributor Author

@wormat how are we going to publish the modules? Merge this one first, publish, then merge again?

@wormat
Copy link
Collaborator

wormat commented Oct 26, 2022

@nicomiicro I think we just merge this into aptos/contracts without publishing and publish when that branch is ready to merge.

@nicomiicro
Copy link
Contributor Author

@wormat ok. That would be ready when "Add to pool" works, right?

@nicomiicro nicomiicro marked this pull request as ready for review October 26, 2022 09:56
@nicomiicro nicomiicro merged commit 823318a into aptos/contracts Oct 26, 2022
@nicomiicro nicomiicro deleted the aptos/add-to-pool branch October 26, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wormat wormat wormat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicomiicro @wormat