Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): warn from-source builders that syncthing auto-upgrades #882

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

orblivion
Copy link
Contributor

Some people may prefer to build from source for their own use. They should be aware that the default behavior is to overwrite the binary with a new downloaded binary when an upgrade is available.

@orblivion
Copy link
Contributor Author

Speaking for myself, I was taken by (unpleasant) surprise here when I realized it was happening. I think there should at least be a warning.

Some people may prefer to build from source for their own use. They should be aware that the default behavior is to overwrite the binary with a new downloaded binary when an upgrade is available.
Copy link
Member

@acolomb acolomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition. I snuck in some changes for consistency, always using --double-dash option style.

@acolomb acolomb changed the title Warn from-source builders that syncthing auto-upgrades chore(dev): warn from-source builders that syncthing auto-upgrades Jan 6, 2025
@acolomb acolomb merged commit 724512c into syncthing:main Jan 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants