validate t,f0 shape (should be equal) in F0. validate non-empty f0 list

.pre-commit-config.yaml

@@ -56,7 +56,7 @@ repos:
     rev: v0.982
     hooks:
     - id: mypy
-      additional_dependencies: [types-redis, types-tabulate]
+      additional_dependencies: [types-redis, types-tabulate, pydantic]
 
   - repo: https://github.com/RobertCraigie/pyright-python
     rev: v1.1.302

pitch_detectors/algorithms/ensemble.py

@@ -30,6 +30,8 @@ def vote_and_median(
     for i, (name, data) in enumerate(algorithms.items()):
         t = data.t
         f0 = data.f0
+        if len(f0) == 0:
+            raise ValueError(f'algorithm {name} returned an empty f0 array')
         f0_resampled[name] = np.full_like(t_resampled, fill_value=np.nan)
         notna_slices = np.ma.clump_unmasked(np.ma.masked_invalid(f0))
 

pitch_detectors/schemas.py

@@ -1,5 +1,8 @@
+from typing import Any
+
 import numpy as np
 from pydantic import BaseModel
+from pydantic import root_validator
 
 
 class ArbitraryBaseModel(BaseModel):
@@ -16,6 +19,12 @@ class F0(ArbitraryBaseModel):
     t: np.ndarray
     f0: np.ndarray
 
+    @root_validator
+    def check_shape(cls, values: dict[str, Any]) -> dict[str, Any]:  # pylint: disable=no-self-argument
+        if values['t'].shape != values['f0'].shape:
+            raise ValueError('t and f0 must have the same shape')
+        return values
+
 
 class Record(ArbitraryBaseModel):
     fs: int | None = None

pyproject.toml

@@ -108,6 +108,9 @@ warn_return_any = true
 warn_unreachable = true
 warn_unused_configs = true
 warn_unused_ignores = true
+plugins = [
+    "pydantic.mypy",
+]
 
 [[tool.mypy.overrides]]
 module = ["tests.*"]

tests/conftest.py

@@ -10,7 +10,7 @@
 @pytest.fixture
 def record():
     fs, a = util.load_wav(Path(__file__).parent.parent / 'data' / 'b1a5da49d564a7341e7e1327aa3f229a.wav')
-    return Record(fs, a)
+    return Record(fs=fs, a=a)
 
 
 @pytest.fixture