Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1265 - Tapestry 3.0 - Show (i) icon on lightbox to show description and copyright/references #1276

Closed
wants to merge 11 commits into from
Closed

1265 - Tapestry 3.0 - Show (i) icon on lightbox to show description and copyright/references #1276

wants to merge 11 commits into from

Conversation

legendword
Copy link
Contributor

@legendword legendword commented Nov 9, 2022 •
edited
Loading

Changes

  • Add (i) icon besides the favourite icon on the top right corner of the lightbox.
  • The (i) button toggles a panel that drops down to show the same information as displayed in the sidebar (description, licenses, and references).

Screenshot

image

Issue Linkage

Closes #1265

PR Dependency

Depends on: #1199

Automated Testing

  • To be added.

@legendword legendword linked an issue Nov 9, 2022 that may be closed by this pull request
Show (i) icon on lightbox to show description and copyright/references #1265
Open
@cypress
Copy link

cypress bot commented Nov 10, 2022 •
edited
Loading


Test summary

100 • 0 • 0 • 0 • Flakiness 1

Run details
Project tapestry-wp
Status Passed
Commit 55dee42
Started Jan 4, 2023 10:06 PM
Ended Jan 4, 2023 10:10 PM
Duration 04:03 💡
OS Linux Ubuntu - 22.04
Browser Chrome 108

View run in Cypress Dashboard ➡️

Flakiness

cypress/integration/lightbox/video.spec.js 1 Flakiness
1 Video > should be able to add a video node via Kaltura and use Kaltura player

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@legendword legendword mentioned this pull request Nov 27, 2022
Closed
@legendword legendword added the needs final review Has been tested and reviewed once and needs another code review to become ready for merge label Nov 30, 2022
@wynnset wynnset changed the title 1265 - Show (i) icon on lightbox to show description and copyright/references 1265 - Tapestry 3.0 - Show (i) icon on lightbox to show description and copyright/references Jan 3, 2023
@wynnset wynnset closed this Jan 6, 2023
@wynnset wynnset deleted the 1265-node-info-on-lightbox branch January 18, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wynnset wynnset

Labels
needs final review Has been tested and reviewed once and needs another code review to become ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show (i) icon on lightbox to show description and copyright/references
2 participants
@legendword @wynnset