-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump testcontainers-java-tarantool to 1.2.0 #444
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,7 +56,6 @@ public static void setUp() throws URISyntaxException, SSLException { | |
.withUsername("test_user") | ||
.withPassword("test_password") | ||
.withMemtxMemory(256 * 1024 * 1024) | ||
.withDirectoryBinding(RESOURCE_PATH + "ssl") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you won't get files that are placed in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed it for enterprise tests |
||
.withLogConsumer(new Slf4jLogConsumer(log)) | ||
.withSslContext(org.testcontainers.containers.SslContext.getSslContext()); | ||
|
||
|
@@ -66,7 +65,6 @@ public static void setUp() throws URISyntaxException, SSLException { | |
.withUsername("test_user") | ||
.withPassword("test_password") | ||
.withMemtxMemory(256 * 1024 * 1024) | ||
.withDirectoryBinding(RESOURCE_PATH) | ||
.withLogConsumer(new Slf4jLogConsumer(log)); | ||
|
||
if (!containerWithSsl.isRunning()) { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ local ok, err = cartridge.cfg({ | |
'app.roles.api_storage', | ||
'app.roles.custom', | ||
}, | ||
cluster_cookie = 'testapp-cluster-cookie', | ||
cluster_cookie = 'secret-cluster-cookie', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it is default value and you can just remove this whole line There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed |
||
}, { | ||
readahead = 10 * 1024 * 1024, -- 10 MB | ||
net_msg_max = 11140, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,24 @@ | ||
testapp.router: | ||
workdir: ./tmp/db_dev/3301 | ||
advertise_uri: localhost:3301 | ||
advertise_uri: 0.0.0.0:3301 | ||
http_port: 8081 | ||
|
||
testapp.second-router: | ||
workdir: ./tmp/db_dev/3302 | ||
advertise_uri: localhost:3302 | ||
advertise_uri: 0.0.0.0:3302 | ||
http_port: 8082 | ||
|
||
testapp.third-router: | ||
workdir: ./tmp/db_dev/3303 | ||
advertise_uri: localhost:3303 | ||
advertise_uri: 0.0.0.0:3303 | ||
http_port: 8083 | ||
|
||
testapp.s1-storage: | ||
workdir: ./tmp/db_dev/3304 | ||
advertise_uri: localhost:3304 | ||
advertise_uri: 0.0.0.0:3304 | ||
http_port: 8084 | ||
|
||
testapp.s2-storage: | ||
workdir: ./tmp/db_dev/3305 | ||
advertise_uri: localhost:3305 | ||
advertise_uri: 0.0.0.0:3305 | ||
http_port: 8085 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
testapp.1: | ||
workdir: ./tmp/db_dev/3301 | ||
advertise_uri: localhost:3301 | ||
advertise_uri: 0.0.0.0:3301 | ||
http_port: 8081 | ||
|
||
testapp.2: | ||
workdir: ./tmp/db_dev/3302 | ||
advertise_uri: localhost:3302 | ||
advertise_uri: 0.0.0.0:3302 | ||
http_port: 8082 | ||
|
||
testapp.3: | ||
workdir: ./tmp/db_dev/3303 | ||
advertise_uri: localhost:3303 | ||
advertise_uri: 0.0.0.0:3303 | ||
http_port: 8083 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get how this works. Please explain how does a container get needed files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous version of the test containers (e.g., 1.0.1):
/app
directory./app
working directory. This step is where the image is built.cartridge build
command (dependency rocks are downloaded into the working directory at this point).Key point:
the dependency rocks are downloaded into the/app
directory related to the container. But docker looks at the cartridge folder that was mapped earlier in the build phase.So binding works with 1.0.1
New version of testcontainers:
Copying the
/cartridge
directory and executing cartridge build happens during the image build phase.Key point:
when using the.withDirectoryBinding
method at the container startup stage, docker will look at the/cartridge
directory that doesn't have the built rocks dependencies in it.So binding doesn't work with new testcontainers.