Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up fix for parsing non-utf8 chars (part 2) #445

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

Gumix
Copy link
Contributor

@Gumix Gumix commented Aug 2, 2024

This patch is similar to commit 52d3e4f ("Follow-up fix for parsing non-utf8 chars"),
but fixes the --verbose output, e.g.:

$ ./test-run.py --verbose some_test

[...]
[001] Worker "001_xxx-luatest" received the following error; stopping...
[001] Traceback (most recent call last):
[001]   File "./tarantool/test-run/lib/worker.py", line 357, in run_task
[001]     short_status, duration = self.suite.run_test(
[001]                              ^^^^^^^^^^^^^^^^^^^^
[001]   File "./tarantool/test-run/lib/test_suite.py", line 271, in run_test
[001]     short_status = test.run(server)
[001]                    ^^^^^^^^^^^^^^^^
[001]   File "./tarantool/test-run/lib/test.py", line 232, in run
[001]     color_stdout(f.read(), schema='log')
[001]                  ^^^^^^^^
[001]   File "<frozen codecs>", line 322, in decode
[001] UnicodeDecodeError: 'utf-8' codec can't decode byte 0xa3 in position 115111: invalid start byte
[001]
[001] Exception: 'utf-8' codec can't decode byte 0xa3 in position 115111: invalid start byte

Follow-up #442

This patch is similar to commit 52d3e4f ("Follow-up fix for parsing
non-utf8 chars"), but fixes the `--verbose` output, e.g.:

```
$ ./test-run.py --verbose some_test

[...]
[001] Worker "001_xxx-luatest" received the following error; stopping...
[001] Traceback (most recent call last):
[001]   File "./tarantool/test-run/lib/worker.py", line 357, in run_task
[001]     short_status, duration = self.suite.run_test(
[001]                              ^^^^^^^^^^^^^^^^^^^^
[001]   File "./tarantool/test-run/lib/test_suite.py", line 271, in run_test
[001]     short_status = test.run(server)
[001]                    ^^^^^^^^^^^^^^^^
[001]   File "./tarantool/test-run/lib/test.py", line 232, in run
[001]     color_stdout(f.read(), schema='log')
[001]                  ^^^^^^^^
[001]   File "<frozen codecs>", line 322, in decode
[001] UnicodeDecodeError: 'utf-8' codec can't decode byte 0xa3 in position 115111: invalid start byte
[001]
[001] Exception: 'utf-8' codec can't decode byte 0xa3 in position 115111: invalid start byte
```
@coveralls
Copy link

Coverage Status

coverage: 62.656% (-0.04%) from 62.696%
when pulling 395d619 on iverbin/fix-non-utf8-chars-parsing
into f23b535 on master.

@Gumix Gumix requested a review from ylobankov August 2, 2024 15:47
@ylobankov ylobankov merged commit 7acc532 into master Oct 24, 2024
21 checks passed
@ylobankov ylobankov deleted the iverbin/fix-non-utf8-chars-parsing branch October 24, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants