Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pagination for get transaction history #1343

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

mmrrnn
Copy link
Collaborator

@mmrrnn mmrrnn commented Jan 3, 2025

Fixes:

Description

Since tari-project/tari#6733 is merged, we can now implement pagination for infinite scrolling. Wallets with extensive transaction history can now open latest wins tab without performance issues.

Changes

  • Infinite scrolling in the "latest wins" tab
  • Filter only COINBASE_UNCONFIRMED and COINBASE_CONFIRMED transactions(blocks wins). Rename methods from get_transaction_history to get_coinbase_transactions to reflect changes.
  • get_coinbase_transactions handles pagination - we define continuation and limit(can be ommitted to fetch all at once)
  • We fetch already ordered transactions, we don't need to sort it again
  • Refresh the data everytime when either we open "recent wins" tab or new block is mined
  • Split Wallet component into WalletMarkup and History to improve performance(reduce rerenders)

Testing

Just play with the "recent wins" tab

@mmrrnn mmrrnn added the on hold Issue is being held for progress later label Jan 3, 2025
@mmrrnn mmrrnn changed the title Pagination for get transaction history chore: pagination for get transaction history Jan 3, 2025
@mmrrnn mmrrnn removed the on hold Issue is being held for progress later label Jan 17, 2025
@mmrrnn mmrrnn marked this pull request as ready for review January 17, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants