Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): check gem amount before showing bonus tier animation #1385

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

shanimal08
Copy link
Collaborator

@shanimal08 shanimal08 commented Jan 15, 2025

Description

just checking there is an actual gem amount before showing the 'GoalComplete' bonus tier animation.

a feature flag was suggested, as we will be using bonus tiers later, but i don't think it's necessary if the amount currently just isn't there from the airdrop BE

Motivation and Context

resolves #1372

How Has This Been Tested?

locally by manually triggering the animation with gem amounts x no gems

What process can a PR reviewer use to test or verify this change?

on nextnet,

  • be logged in and refer a friend
  • get normal invite gift animation
  • ensure the 'gifting goal' animation doesn't pop up after with ✨0✨ gems awarded

@shanimal08 shanimal08 marked this pull request as draft January 15, 2025 11:30
@shanimal08 shanimal08 changed the title fix(ui): check gem amount before showing bonus tier animation fix(ui): check gem amount before showing bonus tier animation Jan 15, 2025
@shanimal08 shanimal08 marked this pull request as ready for review January 15, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the bonus tier animation
1 participant