-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): release version 0.8.45 #1408
Merged
+677
−428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR opens a confirmation modal when the user chooses the "Ludicrous" mining mode. This is to warn them that this mode may cause performance issues on their system. Clicking the "Keep Changes" button triggers to minding mode switch. Closing the modal or clicking "Revert to ECO" wont make any change. There's a countdown that closes the modal automatically after 30 seconds. ![CleanShot 2025-01-06 at 15 36 15](https://github.com/user-attachments/assets/daf29c32-d97c-4222-bae4-d517e5b2d4d1) ![CleanShot 2025-01-06 at 15 35 59](https://github.com/user-attachments/assets/764435bf-b1bf-4295-b987-db698163b0b3) --------- Co-authored-by: Brian Pearce <[email protected]>
This PR adds a max width of `1000px` to the settings modal. On larger screens the modal gets too wide making it more difficult to visually line up the buttons with the text labels. Basically everything is too spread out. Before: ![CleanShot 2025-01-02 at 11 23 06](https://github.com/user-attachments/assets/052995be-78b1-42ac-ba11-1f90c5cd84e7) After: ![CleanShot 2025-01-02 at 11 23 55](https://github.com/user-attachments/assets/5aa160b4-c080-42b3-a952-1e65c6445c2e) Co-authored-by: shan <[email protected]>
Just cleaning up some of the intro animations so they flow more smoothly. This happens between the splash screen -> setup screen & setup screen -> dashboard. https://github.com/user-attachments/assets/c0702db3-1f3b-4ca2-ae8f-82b438235b4f https://github.com/user-attachments/assets/ed164048-4b5f-45c4-a2fb-fc2e5f7d1bae --------- Co-authored-by: Brian Pearce <[email protected]>
Description new translations Motivation and Context new translations How Has This Been Tested? locally What process can a PR reviewer use to test or verify this change? on startup see the new 30% minotari node status in other languages <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain --> Co-authored-by: Brian Pearce <[email protected]>
This PR fixes the layout shifting on the Gems animated number. using `NumberFlow` would also fix this, but i'm adding this as a quick little improvement while we wait for the full integration of `NumberFlow`. Here's a video showing the improvement. It shows the current version at first, then the improved version at the 8 second mark. https://github.com/user-attachments/assets/3f6e9553-31b0-4141-8230-82ca2dde07a0 Co-authored-by: Brian Pearce <[email protected]>
Description --- Resolves #1353 Add GPU reward estimation Motivation and Context --- There was already implementation for CPU miner but GPU was showing no rewards which would be confusing for users. How Has This Been Tested? --- Run TU on nextnet and hover over estimated reward and verify that GPU estimation is non zero. For more precise testing I have compared my hashrate against entire network (the sha3) from [textexplorer](https://textexplore-nextnet.tari.com/) Esmeralda gives strange result with such precise testing since there are very few miners and in some cases miner sha3 hashrate might seem higher than entire network (since it;s average that needs to adjust) What process can a PR reviewer use to test or verify this change? --- Same as above. Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify --------- Co-authored-by: Brian Pearce <[email protected]>
Description --- Added the new base node gRPC call `get_network_state` to `fn get_network_hash_rate_and_block_reward` that returns all required base node statuses in a single call. **The new base node gRPC call `get_network_state` came with the new Tari base layer nextnet release, `v1.10.0-rc.0`** `MinerMetrics` now has additional members - `initial_sync_achieved` (renamed from `is_synced`, describing the actual status) - `failed_checkpoints` - `base_node_state` and also provides a method `MinerMetrics::is_synced()` that will return the is-synced status based on the `base_node_state`. **Notes:** - New `MinerMetrics` must be wired into the code where applicable. Motivation and Context --- To implement the new more efficient base node gRPC method call How Has This Been Tested? --- CI What process can a PR reviewer use to test or verify this change? --- Code review <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [X] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain --> --------- Co-authored-by: Brian Pearce <[email protected]> Co-authored-by: brianp <[email protected]>
Description --- - ~~moved gl app logic out of `index.html` (-> `visuals.ts`) & actually remove canvas entirely when toggling visual mode, instead of just hiding it~~ moving to separate PR - moved the Visual Mode toggle out of 'Experimental' Settings to General Settings - removed the listener for `frontend_ready` from RunEvent:Ready and used `.on_page_load` instead, including the tauri state value of `is_setup_finished` so we can skip the setup screens on the frontend if that's already done and the `setup_message` events won't be emitted again - also added `ProgressTracker`'s `.send_last_action` in there so if it _is_ still setting up, we can continue on and show the actual progress on the FE where it was before the restart/refresh - adjusted `useAppStateStore` a bit so we don't start with a truly value for the setup check (most of the file changes were amending the uses of `isSettingUp` after changing that around, sorry!) Main files with actual changes --- - ~~items moved from [`index.html`](https://github.com/tari-project/universe/pull/1402/files#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051) to [`src/visuals.ts`](https://github.com/tari-project/universe/pull/1402/files#diff-5f2854a948facaeb956b06299de2f47fd38733eb7cd85f5b6ed8edee49bf1fbb) (minor additions in `src/visuals.ts`~~ moving to separate PR - [`src-tauri/main.rs`](https://github.com/tari-project/universe/pull/1402/files#diff-2f5e0a90d4195e9986f5e24928dce16b59a80a2cf30f7059b38d55bd7d1eff69) - setup progress addition to [`src/hooks/app/isAppReady.ts`](https://github.com/tari-project/universe/pull/1402/files#diff-95c4d89aef2e2cee2be8a93864b2975ff76cc54eacadb0a0ee8238ed54bca36a) - ~~cleanups + preload animation in [`src/hooks/app/useSetUp.ts`](https://github.com/tari-project/universe/pull/1402/files#diff-818735307e6ef43bcc35e6609d72a1580524718a151bf5cf8d4d192c46ef5a41)~~ moving to separate PR - neatening and moved some actions out of the main store in [`src/store/appStateStore.ts`](https://github.com/tari-project/universe/pull/1402/files#diff-0d2e757ebac18751f8a38695036dc9f6a8e005c6a2cd7915dc7cafe49a05c5f2) so they can be used outside of hooks/don't need to be added as deps Motivation and Context --- #1400 + the issue of setup getting stuck either at 0% or 100% How Has This Been Tested? --- locally doesn't get stuck on zero if there's a refresh for whatever reason (likely crash + restarts in prod builds/auto update), and `setup_inner` isn't triggered again because `is_setup_finished` is already true: https://github.com/user-attachments/assets/bf812724-4742-4526-924e-94403f9cc597 refreshing/a reload after setup is complete goes straight to the main view + ~~canvas is completely removed on visual mode toggle~~ (moving to separate PR): https://github.com/user-attachments/assets/52d00998-6069-4a2a-975b-eb4cf809e99d
Description release notes
Co-authored-by: Brian Pearce <[email protected]>
stringhandler
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Onwards and upwards