Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature (HK-78): Deploy 파이프라인 수정 #15

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Feature (HK-78): Deploy 파이프라인 수정 #15

merged 2 commits into from
Jan 8, 2025

Conversation

jinlee1703
Copy link
Contributor

@jinlee1703 jinlee1703 commented Jan 7, 2025 •
edited by jira bot
Loading

Motivation

  • HK-78 참고
  • 서버 다이어트(HK-77 참고) 차 EC2 인스턴스 삭제 필요성 대두

Problem Solving

  • Dockerfile 작성
  • GitHub Actions Secrets 수정
    • SERVER_HOST 수정
    • DOCKER_USERNAME 추가
    • DOCKER_PASSWORD 추가

To Reviewer

  • Dockerfile에 각 라인의 역할을 작성해놨으니 참고하시면 좋을 것 같습니다.

Expected effect

  • 기존 인스턴스 삭제를 통한 AWS 비용 절감 기대

@jinlee1703 jinlee1703 added the enhancement New feature or request label Jan 7, 2025
@jinlee1703 jinlee1703 requested a review from juiuj January 7, 2025 11:30
@jinlee1703 jinlee1703 self-assigned this Jan 7, 2025
@aws-amplify-ap-northeast-2 AWS Amplify (ap-northeast-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-15.d15ua1f8x2sllg.amplifyapp.com

juiuj
juiuj approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@juiuj juiuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 수고하셨습니다~!

@jinlee1703 jinlee1703 merged commit d85fe6a into main Jan 8, 2025
2 checks passed
@jinlee1703 jinlee1703 mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juiuj juiuj juiuj approved these changes

Assignees

@jinlee1703 jinlee1703

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinlee1703 @juiuj