Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipNull for ConvertingPopulator as well #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mike4git
Copy link
Collaborator

@mike4git mike4git commented Dec 3, 2024

ConvertingPopulator is just a comfortable wrapper for the PropertyMappingPopulator and therefore it should also be possible to skip null values.

Copy link
Member

@jdreesen jdreesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also support this in the populator configuration, see #69.

@jdreesen
Copy link
Member

jdreesen commented Dec 3, 2024

By the way:
Instead of naming the commit message in co-working with Merlin Tramp it would be better to actually add him as a co-author, by adding this at the end of the commit message:

Co-authored-by: Merlin Tramp [email protected]

@jdreesen jdreesen mentioned this pull request Dec 3, 2024
@mike4git
Copy link
Collaborator Author

mike4git commented Dec 4, 2024

Has been merged by other PR #69

@mike4git mike4git closed this Dec 4, 2024
@mtramp-neusta
Copy link
Contributor

@mike4git How was this merged by PR #69 ?

@jdreesen
Copy link
Member

jdreesen commented Dec 5, 2024

It wasn't. But it should add setting it via config, as #69 did.

@jdreesen jdreesen reopened this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants