Test server support for Nexus operation complete before start #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
Dec 17, 2024
There was a problem hiding this comment.
LGTM but I'm not super familiar with this codebase. Will defer to @Quinn-With-Two-Ns for approval.
| ctx -> { | ||
| StateMachine<NexusOperationData> operation = | ||
| getPendingNexusOperation(ref.getScheduledEventId()); | ||
| if (operation.getState() == State.INITIATED) { |
There was a problem hiding this comment.
To save me from reading, does this cover when the activity is backing off and scheduled?
There was a problem hiding this comment.
Yes, it goes back to INITIATED when backing off.
Quinn-With-Two-Ns
approved these changes
Dec 23, 2024
Quinn-With-Two-Ns
force-pushed
the
test-server-nexus-complete-before-start
branch
from
4b284ce to
6549d8c
Compare
|
@pdoerner is this good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added support to the test server for completing Nexus operations before the start response is received.