Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mdz deploy): Make watch by default (Updated PR) #136

Conversation

tddschn
Copy link
Contributor

@tddschn tddschn commented Aug 9, 2023

Hi @gaocegege , I've been learning Go and now I think I have a much better understanding of the language, esp. how the module / package works.

Since the repo has been converted to public, I lost write access and here's a PR for #55 based on my fork.

tddschn and others added 30 commits July 31, 2023 16:29
@gaocegege
Copy link
Member

Please rebase the upstream. Thanks!

@tddschn
Copy link
Contributor Author

tddschn commented Aug 9, 2023

Should I base it off the 55-mdz-deploy-watch-by-default or the main branch?

To base it off main I think I'll have to open another PR.

To merge to upstream's 55-mdz-deploy-watch-by-default branch, you could try the Squash and Merge button on the GitHub UI. :)

@gaocegege
Copy link
Member

Could you close the previous PR, then file a new one in the upstream?

@tddschn
Copy link
Contributor Author

tddschn commented Aug 9, 2023

Of course. Please see #137 .

@tddschn tddschn closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants