Fix for clearing DEST zero flags when it occurs on the same cycle as ZEROACC instruction #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to bug in Blackhole Tensix (details in https://yyz-gitlab.local.tenstorrent.com/tenstorrent/budabackend/-/issues/2730) when an event with side effect of clearing DEST zero flags (such as Unpack-to-dest or RISC-to-dest) and a ZEROACC instruction from packer occur in the same cycle, zero flags clearing is dropped.
To mitigate that, we issue additional zero flag clear instruction immediately after unpack tile to dest is done. That ensures zero flags are cleared even if ZEROACC overlaps with unpack-to-dest event.
RISC-to-dest event (which can suffer from the same issue) is not currently used.