Fix load/store mode for add int32 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvelickovicTT
approved these changes
Dec 10, 2024
| inline void _add_int32_(const uint dst_offset) { | ||
| // Operand A is input1 (int32) | ||
| // Operand B is input2 (int32) | ||
| // Output is int32 | ||
|
|
||
| // Modifies LOAD/STORE to work with INT32 2's complement. Does not convert to INT32 sign-magnitude. | ||
| // Modifies LOAD/STORE to do INT32 sign-magnitude to 2's complement conversion, however | ||
| // in Blackhole this has no effect and format remains in original format. | ||
| constexpr auto INSTR_MOD_LOAD_STORE = InstrModLoadStore::INT32_2S_COMP; |
There was a problem hiding this comment.
Should this also depend on SIGN_MAGNITUDE_FORMAT flag in principle? I know in BH it doesn't have any effect, but you showed it matters in WH.
There was a problem hiding this comment.
Yes it should, I was told that InstrModLoadStore::INT32 was removed so this is the only option now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add int32 needs the values in SFPU LREGS to be in 2's complement for negative addition to work properly.