Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#15713: Use ZEROACC properly for FP32 case #59

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

ncvetkovicTT
Copy link
Contributor

@ncvetkovicTT ncvetkovicTT commented Dec 16, 2024

Corrected ZEROACC call for fp32 bcasted eltwise mul. Tested by tt-metal post-commit:
https://github.com/tenstorrent/tt-metal/actions/runs/12354236372
and BH post-commit:
https://github.com/tenstorrent/tt-metal/actions/runs/12355477287

(later post-commit runs fail because there are issues with the pipeline #22539, #22474, #2408)

This PR resolves tenstorrent/tt-metal#15713

@ncvetkovicTT
Copy link
Contributor Author

@nvelickovicTT Pipeline is broken, but I have run broadcast unit tests locally and within the two passing workflow runs (before they broke):

[       OK ] ComputeSingleTileBroadcast/BroadcastParameterizedDeviceFixture.TensixComputeSingleTileBroadcast/35 (910 ms)
[----------] 36 tests from ComputeSingleTileBroadcast/BroadcastParameterizedDeviceFixture (30752 ms total)

[----------] Global test environment tear-down
[==========] 36 tests from 1 test suite ran. (30752 ms total)
[  PASSED  ] 33 tests.
[  SKIPPED ] 3 tests, listed below:
[  SKIPPED ] ComputeSingleTileBroadcast/BroadcastParameterizedDeviceFixture.TensixComputeSingleTileBroadcast/12
[  SKIPPED ] ComputeSingleTileBroadcast/BroadcastParameterizedDeviceFixture.TensixComputeSingleTileBroadcast/21
[  SKIPPED ] ComputeSingleTileBroadcast/BroadcastParameterizedDeviceFixture.TensixComputeSingleTileBroadcast/30
                 Device | INFO     | Closing user mode device drivers

@ncvetkovicTT ncvetkovicTT merged commit 10394b3 into main Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Blackhole] Race in PACK/MATH for mul_tiles_bcast_cols
2 participants