Added config registers readers #63
Conversation
| relu_config_u config; | ||
|
|
||
| // Get pointer to registers for current state ID | ||
| volatile uint tt_reg_ptr *cfg = get_cfg_pointer(); |
There was a problem hiding this comment.
Why not keep the same approach as for read_pack_config? Where cfg is passed as argument?
| @@ -519,4 +519,54 @@ namespace ckernel::packer | |||
| TTI_STOREIND (1, 0, p_ind::LD_16B, LO_16(0), p_ind::INC_NONE, p_gpr_pack::TILE_HEADER, p_gpr_pack::OUTPUT_ADDR); | |||
| } | |||
|
|
|||
| // READERS FOR CONFIG STRUCTS | |||
|
|
|||
| inline pack_config_t read_pack_config(uint32_t reg_addr, const volatile uint tt_reg_ptr* cfg) { | |||
There was a problem hiding this comment.
For other functions this is not passed as input since it is known at compile time.
Can you use the same thing here?
| return dest.f; | ||
| } | ||
|
|
||
| inline pck_edge_offset_t read_pck_edge_offset(uint32_t reg_addr, const volatile uint tt_reg_ptr* cfg) { |
There was a problem hiding this comment.
Let's please not use abbreviation. If anything, we should remove the existing ones. pck -> pack
| return edge.f; | ||
| } | ||
|
|
||
| inline pack_counters_t read_pack_counters(uint32_t reg_addr, const volatile uint tt_reg_ptr* cfg) { |
There was a problem hiding this comment.
Same comment about arguments as above. cfg could be obtained inside function and reg_addr should be known at compile time. If true, let's use that.
It also reduces possibility for user errors, as currently user can pass a wrong reg_addr and read pack_config instead of counters, for example.
| alu_config_u config; | ||
| volatile uint tt_reg_ptr *cfg = get_cfg_pointer(); | ||
|
|
||
| config.val = cfg[ALU_ROUNDING_MODE_Fpu_srnd_en_ADDR32]; |
There was a problem hiding this comment.
Will this correctly populate just the FPU rounding bit in the config? Or the whole config, and just the register name is unfortunate?
There was a problem hiding this comment.
This should populate whole config. ALU_ROUNDING_MODE_Fpu_srnd_en_ADDR32 is starting address of the whole config (since fpu_srnd_en is first field in structure). As I understood, we pass to cfg starting address and then it returns 32 bits starting from there.
Added reader functions for configuration registers structs for packer and unpacker