CI: move some vars to env and set persist-credentials: false for actions/checkout@v4 #22519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grimler91
force-pushed
the
CI-hardening
branch
3 times, most recently
from
e1e3639 to
7d7ff62
Compare
persist-credentials=false prevents ssh authentication being available during the job. When we use git we have GITHUB_TOKEN set, so we should not need the auth setup by checkout script.
All variables that can be controlled by an attacker and that are expanded in the scripts can be a risk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recent attack through github actions against https://github.com/ultralytics I had a look at our scripts.
Most of the fixed variables, and
persist-credentials: falsefor actions/checkout@v4, was suggested by zizmor, which @Biswa96 showed me.