Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update README to restrict max hop limit for IMDSv2 #247

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

nitrocode
Copy link
Member

Description

set hops to 1 as per aws recommendation

https://docs.aws.amazon.com/securityhub/latest/userguide/autoscaling-controls.html#autoscaling-4

Motivation and Context

Follow best practices

Breaking Changes

None

How Has This Been Tested?

  • I have tested these changes in my own setup
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs changed the title docs: set hops to 1 docs: Update README to restrict max hop limit for IMDSv2 Oct 30, 2023
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bryantbiggs bryantbiggs merged commit 25eee4b into terraform-aws-modules:master Oct 30, 2023
6 of 7 checks passed
@nitrocode nitrocode deleted the patch-1 branch October 30, 2023 14:31
@antonbabenko
Copy link
Member

This PR is included in version 7.2.0 🎉

Copy link

github-actions bot commented Dec 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants