Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates #49

Merged
merged 5 commits into from
Mar 27, 2024
Merged

updates #49

merged 5 commits into from
Mar 27, 2024

Conversation

chrisnc
Copy link
Collaborator

@chrisnc chrisnc commented Mar 18, 2024

  • add python 3.12
  • update required cffi version
  • uprev actions/setup-python to v5
  • update black

elafargue
elafargue previously approved these changes Mar 19, 2024
@googlebleh
Copy link

googlebleh commented Mar 27, 2024

investigated segfault. tl;dr is that it happens on main too, so it's unrelated to this PR

it's intermittent

cwee@cwee-HP-ZBook-Studio-G7 13:59:55 ~/repos/liblithium remotes/origin/updates
$ docker exec -it act-CI-Linux-Test-08238fc7bee108decdd68893acab34cc4e8ff9b9e096ea80d1fc57c41208bf57 /bin/bash
root@cwee-HP-ZBook-Studio-G7:/home/cwee/repos/liblithium# build/16/test/test_lwc_hash_kat > build/16/test/test_lwc_hash_kat.txt
root@cwee-HP-ZBook-Studio-G7:/home/cwee/repos/liblithium# build/16/test/test_lwc_hash_kat > build/16/test/test_lwc_hash_kat.txt
root@cwee-HP-ZBook-Studio-G7:/home/cwee/repos/liblithium# build/16/test/test_lwc_hash_kat > build/16/test/test_lwc_hash_kat.txt
root@cwee-HP-ZBook-Studio-G7:/home/cwee/repos/liblithium# build/16/test/test_lwc_hash_kat > build/16/test/test_lwc_hash_kat.txt
Segmentation fault (core dumped)

and segfaults in asan startup before running any lithium tests

root@cwee-HP-ZBook-Studio-G7:/home/cwee/repos/liblithium# gdb --ex=run --args env ASAN_OPTIONS='detect_leaks=0' build/16/test/test_lwc_hash_kat
GNU gdb (Ubuntu 12.1-0ubuntu1~22.04) 12.1
...
Type "apropos word" to search for commands related to "word"...
Reading symbols from env...
(No debugging symbols found in env)
Starting program: /usr/bin/env ASAN_OPTIONS=detect_leaks=0 build/16/test/test_lwc_hash_kat
warning: Error disabling address space randomization: Operation not permitted
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
process 3480 is executing new program: /home/cwee/repos/liblithium/build/16/test/test_lwc_hash_kat
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.
0x000060911cd2c441 in __sanitizer::internal_mmap(void*, unsigned long, int, int, int, unsigned long long) ()
(gdb) bt
#0  0x000060911cd2c441 in __sanitizer::internal_mmap(void*, unsigned long, int, int, int, unsigned long long) ()
#1  0x000060911cd2d88a in __sanitizer::MmapNamed(void*, unsigned long, int, int, char const*) ()
#2  0x000060911cd347f8 in __sanitizer::ReservedAddressRange::Init(unsigned long, char const*, unsigned long) ()
#3  0x000060911cc98faa in __sanitizer::SizeClassAllocator64<__asan::AP64<__sanitizer::LocalAddressSpaceView> >::Init(int, unsigned long) ()
#4  0x000060911cc965bd in __asan::Allocator::InitLinkerInitialized(__asan::AllocatorOptions const&) ()
#5  0x000060911cd204d4 in __asan::AsanInitInternal() ()
#6  0x00007a1c249475be in _dl_init (main_map=0x7a1c2497c2e0, argc=1, argv=0x7ffd3b2e6a28, env=0x7ffd3b2e6a38) at ./elf/dl-init.c:102
#7  0x00007a1c249612ca in _dl_start_user () from /lib64/ld-linux-x86-64.so.2
#8  0x0000000000000001 in ?? ()
#9  0x00007ffd3b2e8720 in ?? ()
#10 0x0000000000000000 in ?? ()
(gdb) disas
Dump of assembler code for function _ZN11__sanitizer13internal_mmapEPvmiiiy:
   0x000060911cd2c420 <+0>:     add    %al,(%rax)
   0x000060911cd2c422 <+2>:     add    %al,(%rax)
   0x000060911cd2c424 <+4>:     add    %al,(%rax)
   0x000060911cd2c426 <+6>:     add    %al,(%rax)
   0x000060911cd2c428 <+8>:     add    %al,(%rax)
   0x000060911cd2c42a <+10>:    add    %al,(%rax)
   0x000060911cd2c42c <+12>:    add    %al,(%rax)
   0x000060911cd2c42e <+14>:    add    %al,(%rax)
   0x000060911cd2c430 <+16>:    add    %al,(%rax)
   0x000060911cd2c432 <+18>:    add    %al,(%rax)
   0x000060911cd2c434 <+20>:    add    %al,(%rax)
   0x000060911cd2c436 <+22>:    add    %al,(%rax)
   0x000060911cd2c438 <+24>:    add    %al,(%rax)
   0x000060911cd2c43a <+26>:    add    %al,(%rax)
   0x000060911cd2c43c <+28>:    add    %al,(%rax)
   0x000060911cd2c43e <+30>:    add    %al,(%rax)
   0x000060911cd2c440 <+32>:    add    %al,(%rax)
   0x000060911cd2c442 <+34>:    add    %al,(%rax)
   0x000060911cd2c444 <+36>:    add    %al,(%rax)
   0x000060911cd2c446 <+38>:    add    %al,(%rax)
End of assembler dump.
(gdb) i r
rax            0x600000000000      105553116266496
rbx            0xffffffffffffffff  -1
rcx            0x60911cd2c441      106176370099265
rdx            0x0                 0
rsi            0x40000002000       4398046519296
rdi            0x600000000000      105553116266496
rbp            0x600000000000      0x600000000000
rsp            0x7ffd3b2e68e0      0x7ffd3b2e68e0
r8             0xffffffffffffffff  -1
r9             0x0                 0
r10            0x4032              16434
r11            0x246               582
r12            0x7ffd3b2e6a28      140725596351016
r13            0x7ffd3b2e6a38      140725596351032
r14            0x0                 0
r15            0x4032              16434
rip            0x60911cd2c441      0x60911cd2c441 <__sanitizer::internal_mmap(void*, unsigned long, int, int, int, unsigned long long)+33>
eflags         0x10246             [ PF ZF IF RF ]
cs             0x33                51
ss             0x2b                43
ds             0x0                 0
es             0x0                 0
fs             0x0                 0
gs             0x0                 0

@chrisnc chrisnc merged commit 1d5b7d1 into main Mar 27, 2024
19 checks passed
@chrisnc chrisnc deleted the updates branch March 27, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants