-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(localstack): more reliable legacy tag detection #2936
fix(localstack): more reliable legacy tag detection #2936
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4d651db
to
c8dd734
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, added a comment regarding the non-legacy tags
I just noticed the |
299ea0c
to
c8dd734
Compare
c8dd734
to
09e009d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevenh anything to highlight here? This LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Question (not a blocker at all): do you see we can take the chance to refactor both functions, isLegacyMode and isVersion2 as the code in there is practically the same? I'm approving the PR anyway, so will merge it if you don't consider it for this PR and prefer doing it in a follow-up.
Thanks again for your time 🙇
Definitely. I thought about doing this but didn't want to mess with the code too much as a new contributor. See my latest change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the refactor!
What does this PR do?
Improves the internal
isLegacyMode
function to handle all tag conventions used by localstack.Why is it important?
I'm currently unable to use the much smaller
localstack/localstack:s3-latest
image tag because it's incorrectly detected as a legacy version.How to test this PR
Unit test included.