Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #2940

Merged
merged 2 commits into from
Jan 14, 2025
Merged

chore: fix typos #2940

merged 2 commits into from
Jan 14, 2025

Conversation

NathanBaulch
Copy link
Contributor

What does this PR do?

Fixes a bunch of typos.

Why is it important?

Improves readability and professionalism.

The top typos are:

  • endpoing
  • containerr
  • detault
  • loggin
  • suplied
  • aso
  • credencials
  • dokerfile
  • enpoint
  • serices
  • weavite
  • inititial
  • applcation
  • confif
  • consistenly
  • defering
  • entires
  • entiry
  • prepate
  • referece
  • secific
  • thre
  • underliying
  • unlinke

@NathanBaulch NathanBaulch requested a review from a team as a code owner January 10, 2025 21:44
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/67861f7bb553eac71dff4aab
😎 Deploy Preview https://deploy-preview-2940--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, just a few comments to get this in

docs/modules/ollama.md Show resolved Hide resolved
lifecycle.go Outdated Show resolved Hide resolved
reaper_test.go Outdated Show resolved Hide resolved
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this 🙇

I'm changing the PR title to chore: fix typos as it's not changing the existing behaviour, but fixing typos both in code and the docs. Therefore the PR will land in the Housekeeping section in the release notes.

@mdelapenya
Copy link
Member

BTW @NathanBaulch did you use an automated tool to find the typos? If so, I'd like to use it as part of the lint phase.

@NathanBaulch
Copy link
Contributor Author

BTW @NathanBaulch did you use an automated tool to find the typos? If so, I'd like to use it as part of the lint phase.

I used a combination of https://github.com/crate-ci/typos (automated) and the built-in IntelliJ language tools (manual).

@mdelapenya mdelapenya changed the title fix: typos chore: fix typos Jan 14, 2025
@mdelapenya mdelapenya self-assigned this Jan 14, 2025
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Jan 14, 2025
@mdelapenya
Copy link
Member

I retriggered Netlify's build and created the deployment, although it did not update the GH checks. LGTM anyway

@mdelapenya mdelapenya merged commit 37ca2b4 into testcontainers:main Jan 14, 2025
121 of 125 checks passed
@NathanBaulch NathanBaulch deleted the typos branch January 14, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants