Remove unnecessary Cache system

theodorejb · Dec 11, 2024 · 116a88a · 116a88a
1 parent f7d173d
commit 116a88a
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 350 deletions.
diff --git a/src/Handlebars/Cache.php b/src/Handlebars/Cache.php
diff --git a/src/Handlebars/Cache/APC.php b/src/Handlebars/Cache/APC.php
diff --git a/src/Handlebars/Cache/Disk.php b/src/Handlebars/Cache/Disk.php
diff --git a/src/Handlebars/Cache/Dummy.php b/src/Handlebars/Cache/Dummy.php
diff --git a/src/Handlebars/Handlebars.php b/src/Handlebars/Handlebars.php
@@ -17,7 +17,6 @@
 namespace Handlebars;
 
 use Handlebars\Loader\StringLoader;
-use Handlebars\Cache\Dummy;
 use InvalidArgumentException;
 
 class Handlebars
@@ -51,8 +50,6 @@ public static function factory(array $options = []): Handlebars
 
     private Loader $partialsLoader;
 
-    private Cache $cache;
-
     /**
      * @var callable escape function to use
      */
@@ -78,7 +75,6 @@ public static function factory(array $options = []): Handlebars
      * escapeArgs     => array to pass as extra parameter to escape function
      * loader         => Loader object
      * partials_loader => Loader object
-     * cache          => Cache object
      * enableDataVariables => boolean. Enables @data variables (default: false)
      *
      * @param array $options array of options to set
@@ -99,10 +95,6 @@ public function __construct(Array $options = [])
             $this->setPartialsLoader($options['partials_loader']);
         }
 
-        if (isset($options['cache'])) {
-            $this->setCache($options['cache']);
-        }
-
         if (isset($options['escape'])) {
             if (!is_callable($options['escape'])) {
                 throw new InvalidArgumentException(
@@ -246,25 +238,6 @@ public function getPartialsLoader(): Loader
         return $this->partialsLoader;
     }
 
-    /**
-     * Set cache for current engine
-     */
-    public function setCache(Cache $cache): void
-    {
-        $this->cache = $cache;
-    }
-
-    /**
-     * Get cache
-     */
-    public function getCache(): Cache
-    {
-        if (!isset($this->cache)) {
-            $this->cache = new Dummy();
-        }
-        return $this->cache;
-    }
-
     /**
      * Get current escape function
      */
@@ -413,13 +386,7 @@ public function loadString(string $source): Template
      */
     private function tokenize(string $source): array
     {
-        $hash = md5(sprintf('version: %s, data : %s', self::VERSION, $source));
-        $tree = $this->getCache()->get($hash);
-        if ($tree === false) {
-            $tokens = $this->getTokenizer()->scan($source);
-            $tree = $this->getParser()->parse($tokens);
-            $this->getCache()->set($hash, $tree);
-        }
-        return $tree;
+        $tokens = $this->getTokenizer()->scan($source);
+        return $this->getParser()->parse($tokens);
     }
 }