Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle for Peacock-exclusive content #532

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RDIL
Copy link
Member

@RDIL RDIL commented Nov 18, 2024

Scope

Add toggle for Peacock exclusive content

Currently only works for challenges, as we don't really have a good way of telling what's a Peacock-exclusive contract, but that can be added as a follow-up.

Test Plan

Peacock exclusive challenges do not appear, but others do

Checklist

  • I have run Prettier to reformat any changed files
  • I have verified my changes work

@RDIL RDIL requested a review from Yanrishatum November 18, 2024 00:44
@suanjiansalt
Copy link
Contributor

Some inventory sets are exclusive (non-vanilla) too - this PR is for exclusive content so I put it here.

Copy link
Contributor

@Yanrishatum Yanrishatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the need to update a few challenges that do not bear the peacock tag despite being Peacock challenges (example is Rocco escalation challenge) - seems good to me.

Copy link
Contributor

@AnthonyFuller AnthonyFuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking from merging, I have a plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants