reload library based on fw_image_flag in fw manifest #4669
Conversation
RanderWang
requested review from
bardliao,
lyakh,
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
ujfalusi,
vijendarmukunda,
kuanhsuncheng and
yaochunhung
as code owners
RanderWang
force-pushed
the
library_reload
branch
3 times, most recently
from
fa0ecc0 to
2c20825
Compare
RanderWang
changed the title
RanderWang
force-pushed
the
library_reload
branch
3 times, most recently
from
5cadd53 to
abb78cc
Compare
There was a problem hiding this comment.
@RanderWang, I did not even knew that the fw image have existing flag, this makes it clear. Great!
Few nitpicks from my side.
sound/soc/sof/ipc4-priv.h
Outdated
| #define SOF_IPC4_IMAGE_TYPE GENMASK(2, 1) /* 0 - ROM, 1 - Base FW, 2 -library */ | ||
| #define SOF_IPC4_GET_IMAGE_TYPE(x) (((x) & SOF_IPC4_IMAGE_TYPE) >> 1) | ||
| #define SOF_IPC4_RELOCATABLE_LIB BIT(3) | ||
| #define SOF_IPC4_LIBRARY_RELOAD BIT(4) |
There was a problem hiding this comment.
@mwasko Are we aligned on this?
sound/soc/sof/intel/hda-loader.c
Outdated
| if (reload && hda->booted_from_imr) | ||
| /* if IMR booting is enabled and library reload is not defined, skip the loading */ | ||
| if (reload && hda->booted_from_imr && | ||
| !(ipc4_data->fw_image_flags & SOF_IPC4_LIBRARY_RELOAD)) |
There was a problem hiding this comment.
I would opt for a more generic name still, like SOF_IPC4_CONTEXT_NOT_PRESERVED or something (probably toss in D3 to IMR? or just use comment to clarify it's meaning and keeping it generic).
If we ever want or need to experiment with the context save/restore at large in other parts of the code.
There was a problem hiding this comment.
@ujfalusi I use the name SOF_IPC4_FW_CONTEXT_LOST, how about it ? Thanks!
Driver gets fw_image_flags fw manifest and adopts features based on this flag. Signed-off-by: Rander Wang <[email protected]>
If library reload is not defined by fw, driver can skip library reload on d3 exit or reload library. Signed-off-by: Rander Wang <[email protected]>
RanderWang
force-pushed
the
library_reload
branch
from
abb78cc to
d2e63a6
Compare
|
updated flag name |
There was a problem hiding this comment.
@RanderWang, @mwasko, assuming we are aligned with SOF and reference firmware.
|
no need |
Discussed in converged fw sync meeting and got a conclusion that use a manifest flag
We will set fw_image_flag for library reload in fw config file so library will be reloaded by default. This will not affect ref fw.
Validated on mtl device, with mtl-006 and rimage PR thesofproject/rimage#191