Fix undefined function error for snd_hda_device_is_hdmi #4671
Conversation
charleskeepax
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
bardliao,
ujfalusi,
vijendarmukunda,
kuanhsuncheng and
yaochunhung
as code owners
|
Hm... this does seem to result in a bunch of HDA stuff getting plopped into the components string for the card, which I am not sure if that is intentional. Perhaps this needs further investigation, but I guess at least to report the patch linked in the fixes tag does cause build failures with certain Kconfigs. |
|
I wonder why 5762a2e is not doing it's thing? I have encountered the compilation issue and fixed it with the It should compile, strange. |
|
Yeah that patch does appear to fix the issue I think that must have been some weird build caching or something on my side, closing. |
|
Apologies, it seems my testing last week was off (accidentally still had my fix in the tree), that patch doesn't fix the problem. The problem is that the Kconfig symbol used in the ifdef is not the one that gates the building of function. Incoming patch to fix. |
charleskeepax
force-pushed
the
sof/fix
branch
from
4bf7ae9 to
0a15961
Compare
charleskeepax
changed the title
Right, it should be If you do the update, can you please use |
There was a problem hiding this comment.
@charleskeepax, can you change the commit title to
fixup! ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec
I'm absolutely certain that I had CONFIG_SND_HDA_CODEC_HDMI when I tested this to fix the compile error, but the applied patch says otherwise.
|
Yeah no problem will update the title. |
…MI codec Whether patch_hdmi.c is build into the kernel is controlled by SND_HDA_CODEC_HDMI, not SND_SOC_SOF_HDA_AUDIO_CODEC, update the if def to check this symbol to avoid undefined function issues: ERROR: modpost: "snd_hda_device_is_hdmi" [sound/soc/codecs/snd-soc-hdac-hda.ko] undefined! Fixes: 5762a2e ("ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec") Signed-off-by: Charles Keepax <[email protected]>
charleskeepax
force-pushed
the
sof/fix
branch
from
0a15961 to
1dcbfae
Compare
As snd_hda_device_is_hdmi is now used in hdac_hda.c an additional select is required to ensure the function is built into the kernel.
Fixes: 9c0dfcd ("ASoC: hdac_hda: Conditionally register dais for HDMI and Analog")