ASoC: SOF: Intel: pci-mtl: fix ARL-S definitions, add ARL #4675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial copy/paste from MTL was incorrect, the hardware is different and requires different descriptors along with a dedicated firmware binary. Fixes: 3851831 ("ASoC: SOF: Intel: pci-mtl: use ARL specific firmware definitions") Signed-off-by: Pierre-Louis Bossart <[email protected]>
plbossart
requested review from
bardliao,
lyakh,
lgirdwood,
ranj063,
kv2019i,
dbaluta,
ujfalusi,
vijendarmukunda,
kuanhsuncheng and
yaochunhung
as code owners
plbossart
changed the title
ujfalusi
previously approved these changes
Oct 31, 2023
aiChaoSONG
previously approved these changes
Oct 31, 2023
kv2019i
previously approved these changes
Nov 1, 2023
The PCI ID insertion follows the increasing order in the table, but this hardware follows MTL (MeteorLake). Signed-off-by: Pierre-Louis Bossart <[email protected]>
Add yet another PCI ID - the hardware shares the same descriptors as MTL but we use a dedicated firmware binary file to allow for different signature keys. Signed-off-by: Pierre-Louis Bossart <[email protected]>
Yet another PCI ID. Signed-off-by: Pierre-Louis Bossart <[email protected]>
Same usual filters, SOF is required for DMIC and/or SoundWire support. Signed-off-by: Pierre-Louis Bossart <[email protected]>
plbossart
dismissed stale reviews from kv2019i, aiChaoSONG, and ujfalusi
via
b44d5b7
|
V2: using "ARL" only in PCI ID and comments. |
plbossart
changed the title
ujfalusi
approved these changes
Nov 1, 2023
kv2019i
approved these changes
Nov 1, 2023
ujfalusi
reviewed
Nov 6, 2023
| [SOF_IPC_TYPE_4] = "intel/sof-ipc4/arl", | ||
| }, | ||
| .default_lib_path = { | ||
| [SOF_IPC_TYPE_4] = "intel/sof-ipc4-lib/arl", |
There was a problem hiding this comment.
@plbossart, @kv2019i, I have completely overlooked this, we should have the default paths:
.default_fw_path = {
[SOF_IPC_TYPE_4] = "intel/sof-ipc4/arl-s",
},
.default_lib_path = {
[SOF_IPC_TYPE_4] = "intel/sof-ipc4-lib/arl-s",
},In order to follow the existing patterns. (not to reuse the ARL directory and use different firmware name).
Can we fix this up?
There was a problem hiding this comment.
thanks @ujfalusi indeed, it's a miss. Care to send a fixup! patch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial copy/paste from MTL was incorrect, the hardware is different and requires different descriptors along with a dedicated firmware binary.
Fixes: 3851831 ("ASoC: SOF: Intel: pci-mtl: use ARL specific firmware definitions")