ALSA/hda: intel-sdw-acpi: Correct sdw_intel_acpi_scan() function para… #5279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meter The acpi_handle should be just a handle and not a pointer in sdw_intel_acpi_scan() parameter list. It is called with 'acpi_handle handle' as parameter and it is passing it to acpi_walk_namespace, which also expects acpi_handle and not acpi_handle* Signed-off-by: Peter Ujfalusi <[email protected]>
ujfalusi
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta and
bardliao
as code owners
bardliao
approved these changes
Dec 30, 2024
lgirdwood
approved these changes
Jan 8, 2025
ranj063
reviewed
Jan 8, 2025
| @@ -365,7 +365,7 @@ struct sdw_intel_res { | |||
| * on e.g. which machine driver to select (I2S mode, HDaudio or | |||
| * SoundWire). | |||
| */ | |||
| int sdw_intel_acpi_scan(acpi_handle *parent_handle, | |||
There was a problem hiding this comment.
@ujfalusi can you please give a little more info on how you identified and fixed this?
There was a problem hiding this comment.
We have encountered a kernel crash on a developer setup. It might be caused by incorrect ACPI information. The kernel should never crash even if the ACPI information is incorrect.
|
SOFI TEST |
ranj063
approved these changes
Jan 14, 2025
|
SOFCI TEST |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…meter
The acpi_handle should be just a handle and not a pointer in sdw_intel_acpi_scan() parameter list.
It is called with 'acpi_handle handle' as parameter and it is passing it to acpi_walk_namespace, which also expects acpi_handle and not acpi_handle*