-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASoC: SOF: ipc4-pcm: Delay reporting is only supported for playback d… #5285
base: topic/sof-dev
Are you sure you want to change the base?
ASoC: SOF: ipc4-pcm: Delay reporting is only supported for playback d… #5285
Conversation
…irection The firmware does not provide any information for capture streams via the shared pipeline registers. To avoid reporting invalid delay value for capture streams to user space we need to disable it. Fixes: af74dbd ("ASoC: SOF: ipc4-pcm: allocate time info for pcm delay feature") Cc: [email protected] Signed-off-by: Peter Ujfalusi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is by design in firmware that no pipeline information is kept for capture streams: Somehow the number of fw registers section depends on the number of playback channels: The pipeline regs are only initialized in case of playback, that's why It looks to be by design. |
I can fix this in kernel... |
I could handle this in kernel, but it is only going to work for HD-DMA on link side and even with that it is not going to work in case of a split topology path (one DAI to multiple PCMs). It is better and safer to not report the delay in capture at all. |
We should really fix in FW and support this for capture. @ujfalusi can you create a FW ticket on what you expect and how kernel could detect if available. |
…irection
The firmware does not provide any information for capture streams via the shared pipeline registers.
To avoid reporting invalid delay value for capture streams to user space we need to disable it.
Fixes: af74dbd ("ASoC: SOF: ipc4-pcm: allocate time info for pcm delay feature")
Cc: [email protected]