Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Volume tests are all SKIP with topology v2 (grep PGA) #1069

Closed
marc-hb opened this issue Jun 27, 2023 · 0 comments · Fixed by #1193
Closed

Volume tests are all SKIP with topology v2 (grep PGA) #1069

marc-hb opened this issue Jun 27, 2023 · 0 comments · Fixed by #1193
Assignees
@marc-hb
Labels
P0 urgent Call for attention for urgent issues P1 Blocker bugs or important features type:test coverage gap This requires a new test case, not just fixing one

Comments

@marc-hb
Copy link
Collaborator

marc-hb commented Jun 27, 2023 •
edited
Loading

volume-basic-test.sh, check-volume-levels.sh and maybe others have always been testing only the controls with "PGA" in the name. According to @ranj063 , that "PGA" keyword is gone in topology v2. So these tests don't do anything any more, they just SKIP.

Example: https://sof-ci.01.org/sofpr/PR7854/build10005/devicetest all SKIP

Prototype fix and discussion:
@marc-hb marc-hb added P1 Blocker bugs or important features type:test coverage gap This requires a new test case, not just fixing one labels Jun 27, 2023
@marc-hb marc-hb mentioned this issue Jun 28, 2023
Merged
@marc-hb marc-hb changed the title Volume tests are all SKIP with topology v2 Volume tests are all SKIP with topology v2 (grep PGA) Sep 27, 2023
@marc-hb marc-hb mentioned this issue Jan 2, 2024
Closed
@marc-hb marc-hb added the P0 urgent Call for attention for urgent issues label Apr 17, 2024
@marc-hb marc-hb self-assigned this Apr 17, 2024
marc-hb added a commit to marc-hb/sof-test that referenced this issue May 13, 2024
@marc-hb
volume-basic-test.sh: switch to .tplg parsing to test topologies v2
da8f775 
Until now this test was "screen-scraping" amixer output. This was not
compatible with v2 topologies which means the test was always SKIP for
everything developped on the main branch. Switch to parsing topologies
to extract volume kcontrols.

Fixes: thesofproject#1069, see also discussion in earlier attempt thesofproject#1068.

Signed-off-by: Marc Herbert <[email protected]>
This was referenced May 13, 2024
Merged
Closed
marc-hb added a commit to marc-hb/sof-test that referenced this issue May 14, 2024
@marc-hb
volume-basic-test.sh: switch to .tplg parsing to test topologies v2
b1af0ab 
Until now this test was "screen-scraping" amixer output. This was not
compatible with v2 topologies which means the test was always SKIP for
everything developped on the main branch. Switch to parsing topologies
to extract volume kcontrols.

Fixes: thesofproject#1069, see also discussion in earlier attempt thesofproject#1068.

Signed-off-by: Marc Herbert <[email protected]>
marc-hb added a commit to marc-hb/sof-test that referenced this issue May 14, 2024
@marc-hb
volume-basic-test.sh: switch to .tplg parsing to test topologies v2
5a4cf38 
Until now this test was "screen-scraping" amixer output. This was not
compatible with v2 topologies which means the test was always SKIP for
everything developped on the main branch. Switch to parsing topologies
to extract volume kcontrols.

Fixes: thesofproject#1069, see also discussion in earlier attempt thesofproject#1068.

Signed-off-by: Marc Herbert <[email protected]>
marc-hb added a commit to marc-hb/sof-test that referenced this issue May 14, 2024
@marc-hb
volume-basic-test.sh: switch to .tplg parsing to test topologies v2
1dce3d7 
Until now this test was "screen-scraping" amixer output. This was not
compatible with v2 topologies which means the test was always SKIP for
everything developped on the main branch. Switch to parsing topologies
to extract volume kcontrols.

Fixes: thesofproject#1069, see also discussion in earlier attempt thesofproject#1068.

Signed-off-by: Marc Herbert <[email protected]>
marc-hb added a commit that referenced this issue May 20, 2024
@marc-hb
volume-basic-test.sh: switch to .tplg parsing to test topologies v2
82b4831 
Until now this test was "screen-scraping" amixer output. This was not
compatible with v2 topologies which means the test was always SKIP for
everything developped on the main branch. Switch to parsing topologies
to extract volume kcontrols.

Fixes: #1069, see also discussion in earlier attempt #1068.

Signed-off-by: Marc Herbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marc-hb marc-hb

Labels
P0 urgent Call for attention for urgent issues P1 Blocker bugs or important features type:test coverage gap This requires a new test case, not just fixing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

volume-basic-test.sh: switch to .tplg parsing to test topologies v2 marc-hb/sof-test
1 participant
@marc-hb