Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volume-basic-test.sh: don't skip "playback volume" controls #1068

Closed
wants to merge 1 commit into from

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Jun 27, 2023

Superseded by PR #1193.

Looking for "PGA" is not enough.

Other minor fixes.

cc:

Copy link
Collaborator Author

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a draft for now, reset_sof_volume would have to be fixed too. Maybe also check-volume-levels.sh and some other test.

@marc-hb
Copy link
Collaborator Author

marc-hb commented Jun 27, 2023

Houston, we have a problem
https://sof-ci.01.org/softestpr/PR1068/build502/devicetest/index.html

cmd: TPLG=/lib/firmware/intel/avs-tplg/sof-adl-nocodec.tplg MODEL=ADLP_RVP_NOCODEC_IPC4ZPH ~/sof-test/test-case/volume-basic-test.sh
====================
framework load: ssh  [email protected]  'nohup bash -c "TPLG=/lib/firmware/intel/avs-tplg/sof-adl-nocodec.tplg MODEL=ADLP_RVP_NOCODEC_IPC4ZPH ~/sof-test/test-case/volume-basic-test.sh 2>&1 | nc -N 10.54.29.142 50659" >/dev/null &'
====================
framework run: 'netcat -l -k 50659'
====================
2023-06-27 00:38:35 UTC [REMOTE_INFO] ktime=661 sof-test PID=8285: starting
2023-06-27 00:38:35 UTC [REMOTE_INFO] /home/ubuntu/sof-test/test-case/volume-basic-test.sh will use topology /usr/lib/firmware/intel/avs-tplg/sof-adl-nocodec.tplg to run the test case
2023-06-27 00:38:35 UTC [REMOTE_INFO] Pipeline list to ignore is specified, will ignore 'pcm=HDA Digital' in test case
2023-06-27 00:38:35 UTC [REMOTE_INFO] Run command to get pipeline parameters
2023-06-27 00:38:35 UTC [REMOTE_COMMAND] sof-tplgreader.py /usr/lib/firmware/intel/avs-tplg/sof-adl-nocodec.tplg -f 'type:playback' -b ' pcm:HDA Digital' -s 0 -e
2023-06-27 00:38:35 UTC [REMOTE_INFO] Starting /usr/local/bin/mtrace-reader.py
2023-06-27 00:38:35 UTC [REMOTE_COMMAND] aplay -D hw:0,0 -c 2 -r 48000 -f S16_LE /dev/zero &
Playing raw data '/dev/zero' : Signed 16 bit Little Endian, Rate 48000 Hz, Stereo
numid=11,iface=MIXER,name='eqiir.14.1 DMIC0 capture Iir Eq'
numid=1,iface=MIXER,name='gain.1.1 Pre Mixer Port0 Playback Volume'
numid=10,iface=MIXER,name='gain.13.1 DMIC Raw Capture Volume'
numid=12,iface=MIXER,name='gain.17.1 Post Demux Port0 2nd Capture Volu'
numid=13,iface=MIXER,name='gain.18.1 Post Demux DMIC SFX1 Capture Volu'     <======== truncated !!!
numid=14,iface=MIXER,name='gain.19.1 Pre Demux DMIC SFX1 Capture Volum'
numid=2,iface=MIXER,name='gain.2.1 Post Mixer Port0 Playback Volume'
numid=15,iface=MIXER,name='gain.20.1 Post Demux DMIC SFX2 Capture Volu'
numid=4,iface=MIXER,name='gain.3.1 Pre Mixer Port1 Playback Volume'
numid=5,iface=MIXER,name='gain.4.1 Post Mixer Port1 Playback Volume'

EDIT: all the (new!) tests passed in cavs25 https://sof-ci.01.org/softestpr/PR1068/build502/devicetest/index.html

@ranj063
Copy link
Contributor

ranj063 commented Jun 27, 2023

@marc-hb I am wondering if it makes ense to filter the mixer controls at all based on the name. Why not test all of them. This will mean we end up testing those that aren't created from our topology but I suppose that should be fine. @plbossart what do you think?

@marc-hb marc-hb added type:bug Something doesn't work as expected type:test coverage gap This requires a new test case, not just fixing one labels Jun 27, 2023
Looking for "PGA" is not enough.

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb marc-hb force-pushed the playback-volume branch from 4107881 to fdcf47f Compare July 6, 2023 00:54
@marc-hb
Copy link
Collaborator Author

marc-hb commented Jul 6, 2023

cavs25 still passing volume-basic-test.sh in https://sof-ci.01.org/softestpr/PR1068/build560/devicetest/index.html

volume-basic-test.sh still not part of the ACE test plan in https://sof-ci.01.org/softestpr/PR1068/build562/devicetest/index.html

stable-v2.2 https://sof-ci.01.org/softestpr/PR1068/build561/devicetest/index.html all green.

@plbossart
Copy link
Member

@marc-hb I am wondering if it makes ense to filter the mixer controls at all based on the name. Why not test all of them. This will mean we end up testing those that aren't created from our topology but I suppose that should be fine. @plbossart what do you think?

I don't know if it's possible for topologies that include an EQ and bytes control, where you need to know what to write in the binary data.

@marc-hb
Copy link
Collaborator Author

marc-hb commented Dec 15, 2023

SOFCI TEST

@marc-hb marc-hb marked this pull request as ready for review December 16, 2023 01:05
@marc-hb marc-hb requested a review from a team as a code owner December 16, 2023 01:05
@marc-hb marc-hb added the P1 Blocker bugs or important features label Dec 16, 2023
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 19, 2024

Why not test all of them.

You need to filter on "something", you can't set the volume of "Playback Channel Map" or of
a Mute switch.

How about testing all the controls which have a dBscale-min? Would that make sense?

EDIT: some answers in related:

@marc-hb marc-hb marked this pull request as draft April 22, 2024 21:32
marc-hb added a commit to marc-hb/sof-test that referenced this pull request May 13, 2024
Will be used in next commit to fix thesofproject#1068. See also discussion in earlier
attempt thesofproject#1068.
marc-hb added a commit to marc-hb/sof-test that referenced this pull request May 13, 2024
Until now this test was "screen-scraping" amixer output. This was not
compatible with v2 topologies which means the test was always SKIP for
everything developped on the main branch. Switch to parsing topologies
to extract volume kcontrols.

Fixes: thesofproject#1069, see also discussion in earlier attempt thesofproject#1068.

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb
Copy link
Collaborator Author

marc-hb commented May 13, 2024

Superseded by PR #1193.

Discuss in issue #1069.

@marc-hb marc-hb closed this May 13, 2024
@marc-hb marc-hb deleted the playback-volume branch May 13, 2024 23:20
marc-hb added a commit to marc-hb/sof-test that referenced this pull request May 14, 2024
Will be used in next commit to fix thesofproject#1068. See also discussion in earlier
attempt thesofproject#1068.
marc-hb added a commit to marc-hb/sof-test that referenced this pull request May 14, 2024
Until now this test was "screen-scraping" amixer output. This was not
compatible with v2 topologies which means the test was always SKIP for
everything developped on the main branch. Switch to parsing topologies
to extract volume kcontrols.

Fixes: thesofproject#1069, see also discussion in earlier attempt thesofproject#1068.

Signed-off-by: Marc Herbert <[email protected]>
marc-hb added a commit to marc-hb/sof-test that referenced this pull request May 14, 2024
Will be used in next commit to fix thesofproject#1068. See also discussion in earlier
attempt thesofproject#1068.
marc-hb added a commit to marc-hb/sof-test that referenced this pull request May 14, 2024
Until now this test was "screen-scraping" amixer output. This was not
compatible with v2 topologies which means the test was always SKIP for
everything developped on the main branch. Switch to parsing topologies
to extract volume kcontrols.

Fixes: thesofproject#1069, see also discussion in earlier attempt thesofproject#1068.

Signed-off-by: Marc Herbert <[email protected]>
marc-hb added a commit to marc-hb/sof-test that referenced this pull request May 14, 2024
Will be used in next commit to fix thesofproject#1068. See also discussion in earlier
attempt thesofproject#1068.
marc-hb added a commit to marc-hb/sof-test that referenced this pull request May 14, 2024
Until now this test was "screen-scraping" amixer output. This was not
compatible with v2 topologies which means the test was always SKIP for
everything developped on the main branch. Switch to parsing topologies
to extract volume kcontrols.

Fixes: thesofproject#1069, see also discussion in earlier attempt thesofproject#1068.

Signed-off-by: Marc Herbert <[email protected]>
marc-hb added a commit that referenced this pull request May 20, 2024
Will be used in next commit to fix #1068. See also discussion in earlier
attempt #1068.
marc-hb added a commit that referenced this pull request May 20, 2024
Until now this test was "screen-scraping" amixer output. This was not
compatible with v2 topologies which means the test was always SKIP for
everything developped on the main branch. Switch to parsing topologies
to extract volume kcontrols.

Fixes: #1069, see also discussion in earlier attempt #1068.

Signed-off-by: Marc Herbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
False Pass / green failure P1 Blocker bugs or important features type:bug Something doesn't work as expected type:test coverage gap This requires a new test case, not just fixing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants