-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
volume-basic-test.sh: don't skip "playback volume" controls #1068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a draft for now, reset_sof_volume
would have to be fixed too. Maybe also check-volume-levels.sh and some other test.
Houston, we have a problem
EDIT: all the (new!) tests passed in cavs25 https://sof-ci.01.org/softestpr/PR1068/build502/devicetest/index.html |
@marc-hb I am wondering if it makes ense to filter the mixer controls at all based on the name. Why not test all of them. This will mean we end up testing those that aren't created from our topology but I suppose that should be fine. @plbossart what do you think? |
Looking for "PGA" is not enough. Signed-off-by: Marc Herbert <[email protected]>
cavs25 still passing volume-basic-test.sh in https://sof-ci.01.org/softestpr/PR1068/build560/devicetest/index.html volume-basic-test.sh still not part of the ACE test plan in https://sof-ci.01.org/softestpr/PR1068/build562/devicetest/index.html stable-v2.2 https://sof-ci.01.org/softestpr/PR1068/build561/devicetest/index.html all green. |
I don't know if it's possible for topologies that include an EQ and bytes control, where you need to know what to write in the binary data. |
SOFCI TEST |
You need to filter on "something", you can't set the volume of "Playback Channel Map" or of How about testing all the controls which have a EDIT: some answers in related: |
Will be used in next commit to fix thesofproject#1068. See also discussion in earlier attempt thesofproject#1068.
Until now this test was "screen-scraping" amixer output. This was not compatible with v2 topologies which means the test was always SKIP for everything developped on the main branch. Switch to parsing topologies to extract volume kcontrols. Fixes: thesofproject#1069, see also discussion in earlier attempt thesofproject#1068. Signed-off-by: Marc Herbert <[email protected]>
Will be used in next commit to fix thesofproject#1068. See also discussion in earlier attempt thesofproject#1068.
Until now this test was "screen-scraping" amixer output. This was not compatible with v2 topologies which means the test was always SKIP for everything developped on the main branch. Switch to parsing topologies to extract volume kcontrols. Fixes: thesofproject#1069, see also discussion in earlier attempt thesofproject#1068. Signed-off-by: Marc Herbert <[email protected]>
Will be used in next commit to fix thesofproject#1068. See also discussion in earlier attempt thesofproject#1068.
Until now this test was "screen-scraping" amixer output. This was not compatible with v2 topologies which means the test was always SKIP for everything developped on the main branch. Switch to parsing topologies to extract volume kcontrols. Fixes: thesofproject#1069, see also discussion in earlier attempt thesofproject#1068. Signed-off-by: Marc Herbert <[email protected]>
Will be used in next commit to fix thesofproject#1068. See also discussion in earlier attempt thesofproject#1068.
Until now this test was "screen-scraping" amixer output. This was not compatible with v2 topologies which means the test was always SKIP for everything developped on the main branch. Switch to parsing topologies to extract volume kcontrols. Fixes: thesofproject#1069, see also discussion in earlier attempt thesofproject#1068. Signed-off-by: Marc Herbert <[email protected]>
Until now this test was "screen-scraping" amixer output. This was not compatible with v2 topologies which means the test was always SKIP for everything developped on the main branch. Switch to parsing topologies to extract volume kcontrols. Fixes: #1069, see also discussion in earlier attempt #1068. Signed-off-by: Marc Herbert <[email protected]>
Superseded by PR #1193.
Looking for "PGA" is not enough.
Other minor fixes.
cc: