Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amixer setting for ipc4 platforms #1012

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Amixer setting for ipc4 platforms #1012

merged 2 commits into from
Mar 29, 2023

Conversation

keqiaozhang
Copy link
Contributor

No description provided.

@keqiaozhang keqiaozhang mentioned this pull request Mar 15, 2023
Closed
@marc-hb
Copy link
Collaborator

marc-hb commented Mar 15, 2023

Fix for one of the shellcheck warnings suggested in #1010 (comment)

https://github.com/thesofproject/sof-test/actions/runs/4424462565/jobs/7758320869

This other one is pretty good:

In case-lib/lib.sh line 811:
        APL_UP2_NOCODEC | CML_RVP_NOCODEC | JSL_RVP_NOCODEC |
TGLU_RVP_NOCODEC | ADLP_RVP_NOCODEC | TGLH_RVP_NOCODEC | MTLP_RVP_NOCODEC)



         ^--------------^ SC2221: This pattern always overrides a later one on line 819.

@keqiaozhang keqiaozhang force-pushed the amixer_ipc4 branch 2 times, most recently from c638f1d to 06b1aae Compare March 17, 2023 02:32
@keqiaozhang keqiaozhang mentioned this pull request Mar 17, 2023
Closed
@keqiaozhang
Copy link
Contributor Author

Passed the test on IPC3 platforms:https://sof-ci.01.org/softestpr/PR1012/build206/devicetest/index.html. No side effects.

Tested this PR on IPC4 platforms with https://github.com/intel-innersource/drivers.audio.ci.sof-framework/pull/383:

  1. IPC4-CAVS2.5: https://sof-ci.ostc.intel.com/#/result/planresultdetail/22335
    Test failed on SDW platforms, it's due to known issue:[BUG] Headset capture does not work with S16_LE format on IPC4-SDW platforms sof#7240

  2. IPC4-ACE: https://sof-ci.ostc.intel.com/#/result/planresultdetail/22333
    All failures are identified as known issues:
    MTL-HDA: [BUG][alsabat] glitches happened on MTL-HDA when testing headset recording sof#7298
    MTL-NOCODEC:[BUG] distortion during playback on MTL-NOCODEC sof#6837
    MTL-SDW:[BUG] Headset capture does not work with S16_LE format on IPC4-SDW platforms sof#7240

@keqiaozhang keqiaozhang marked this pull request as ready for review March 17, 2023 07:45
@keqiaozhang keqiaozhang requested a review from a team as a code owner March 17, 2023 07:45
@keqiaozhang
Copy link
Contributor Author

#1010 should be merged first.

@keqiaozhang keqiaozhang mentioned this pull request Mar 21, 2023
Merged
@keqiaozhang
amixer_settings: adjust amixer settings for IPC4 platforms
1011701 
Signed-off-by: Keqiao Zhang <[email protected]>
@keqiaozhang
lib.sh: switch to use reset_sof_volume funtion to adjust
a6520b0 
amixer settings for IPC4 nocodec platforms

Signed-off-by: Keqiao Zhang <[email protected]>
@miRoox
Copy link
Contributor

miRoox commented Mar 28, 2023

Rebase?

@keqiaozhang
Copy link
Contributor Author

Rebase?

Done.

miRoox
miRoox approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@miRoox miRoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice the amixer settings depend on the model in an incompatible way with the hardware/software config. But anyway, we can consider this later.

@keqiaozhang keqiaozhang merged commit 02aafc0 into thesofproject:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miRoox miRoox miRoox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keqiaozhang @marc-hb @miRoox