Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-xrun-injection.sh: refine the xun injection command line #1138

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

keqiaozhang
Copy link
Contributor

Previous command line doesn't work on some platforms, it shows that there's no file or directory. This patch refines the commandline to avoid such issue.

@keqiaozhang keqiaozhang requested a review from a team as a code owner December 6, 2023 02:29
Previous command line doesn't work on some platforms, it shows that
there's no $xrun_injection file or directory. This patch fixes the
bad quoting.

Signed-off-by: Keqiao Zhang <[email protected]>
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good but please avoid the word "refine", it's mostly meaningless. This is a bug fix; call it a fix! For instance: "Fix bad quoting when enabling /proc/.../xrun_injection". Just an idea.

@keqiaozhang keqiaozhang merged commit 871ab5d into thesofproject:main Dec 6, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants