test-case: test-speaker.sh: fix test for PCMs that only support 32bit #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hb
approved these changes
Jan 19, 2024
marc-hb
requested changes
Jan 23, 2024
There was a problem hiding this comment.
The warning in https://github.com/thesofproject/sof-test/actions/runs/7585249087/job/20660669613?pr=1155 is unfortunately valid, relevant and very easy to fix. Sorry!
Always use shellcheck. It's so simple and fast to use.
The speaker-test "wav" test method supports only 48000Hz and 16bit files. If a topology has a PCM that does not support S16_LE, a different speaker-test method must be used. Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
force-pushed
the
202401-fix-speaker-test-part2
branch
from
45df9c8 to
7922a8d
Compare
marc-hb
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The speaker-test "wav" test method supports only 48000Hz and 16bit files. If a topology has a PCM that does not support S16_LE, a different speaker-test method must be used.