Updated check-sof-logger.sh and verify-kernel-boot-log.sh

[harajend]

Updated SOF-specific codecs since the sof* regex also lists sofprobes.

[sofci]

Can one of the admins verify this patch?

reply test this please to run this test once

[marc-hb]

test this please

[marc-hb]

• Are there any other possibilities besides these two? @kv2019i , @ranj063 , @bardliao can you answer?

• The commit message must link to the corresponding bug, e.g. "Fixes issue [BUG] /proc/asound/sofprobes breaks "check-sof-logger" test #1243"

• The commit title and message must describe the change much precisely. For instance: check-sof-logger: remove wildcard from sof_alsa_card_found(). The title has very little space, so don't use words like "update": every commit is an update.

See past commit message examples in the git log.

Here are some good references, most of this applies to any open-source project so please spend some time and take a look

https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines
https://wiki.openstack.org/wiki/GitCommitMessages
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#write-a-meaningful-commit-message
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

[marc-hb]

Are there any other possibilities besides these two?

Answer: it is not enough.

https://sof-ci.01.org/softestpr/PR1245/build795/devicetest/index.html?model=ADLP_RVP_NOCODEC-ipc4&testcase=check-sof-logger

[marc-hb]

Simpler and probably good enough:

sof_alsa_card_found()
{
   for i in /proc/asound/sof*/id; do
      if test -e "$i"; then return 0; fi
   done
   return 1
}

[marc-hb]

You need to use git rebase -i and squash the 2 git commits into a single one. We don't want to keep trial-and-error in the history; every git commit must work. Neither Zephyr nor SOF use Github in the "usual" way, they use it in the "traditional git" way zephyrproject-rtos/zephyr#39194

Also, see advice above for a useful commit message.

[marc-hb]

Jenkins did not test this at all :-(

[marc-hb]

Jenkins did not test this at all :-(

Still not running :-(

[marc-hb]

Jenkins still not running; pushing new versions does not make any difference. Something is wrong on the Jenkins side. cc: @kv2019i

You need to use git rebase -i and squash the 2 git commits into a single one.

Still not done.

[marc-hb]

There is still no testing.

Squashing looks good but the commit message of 212a420 is still a mess:

Updated the test script with suggested changes

Signed-off-by: harajend <[email protected]>

Updated check-sof-logger.sh

Updated SOF-specific codecs since the sof* regex also lists sofprobes.

Signed-off-by: harajend <[email protected]>

Don't say "update", every commit is an update. Just describe the change (once).

[kv2019i]

Mostly good, but some comments inline.

[kv2019i]

Hmm, doesn't this still select a fixed card?

E.g.

~$ aplay -l
**** List of PLAYBACK Hardware Devices ****
card 0: sofhdadsp [sof-hda-dsp], device 0: HDA Analog (*) []
  Subdevices: 1/1
  Subdevice #0: subdevice #0

... you'd get the same with "amixer -c 0" gets us.

[harajend]

Select a card using its name, such as "sofsoundwire", instead of selecting it using numbers

aplay -l | head -2 | tail -1 | awk '{print $3}'

sofsoundwire

Command shall be like: amixer -c "sofsoundwire" cget name='Dmic0 Capture Switch'

[kv2019i]

@harajend But "head -2 | tail -1" will always pick the first card, so this is same as passing "amixer -c 0", right?

[marc-hb]

awk is a "big boy" and can select lines itself. It's shorter AND more readable:

   switch=$(aplay -l |  awk 'NR == 2 {print $3}')

amixer -c 0 looks even better? I'm only simplifying code but I don't know if it is correct.

[harajend]

@harajend But "head -2 | tail -1" will always pick the first card, so this is same as passing "amixer -c 0", right?

Yes, On functionality front both are same. Here I thought to pass "name/identifier" instead of "index number"

[kv2019i]

Change is good, but the commit message seems wrong. There are two signed offs. Can you amend the message and repush?

[marc-hb]

There is still no testing.

Mmm.... Jenkins just started running in unrelated #1247... Let's try something....

[marc-hb]

test this please

[marc-hb]

Jenkins is still not running :-( @harajend please try closing this one and re-submitting in a new PR?

[harajend]

Submitted new PR's for sof-logger and kernel-boot-log failures. Hence closing this (#1245) pull request.
Sof-logger: #1248
Kernel-boot-log: #1249