Fix check-kmod-load-unload. Make it and verify-sof-firmware-load IPC4-compatible #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract new function grep_firmware_info_in_logs() from verify-sof-firmware-load.sh for re-use in other tests. Zero functional change. Signed-off-by: Marc Herbert <[email protected]>
Stop relying on verify-sof-firmware-load.sh in check-kmod-load-unload.sh. The former has some serious issues: - It passes even after unloading the firmware - It has a misleading name - It looks for firmware versions instead of "firmware boot complete", which is not compatible with IPC4. Add new sof_firmware_boot_complete() function that can be re-used to fix verify-sof-firmware-load.sh later. Fixes thesofproject#845 Signed-off-by: Marc Herbert <[email protected]>
For IPC4 compatibility, search for "firmware boot complete" instead of a firmware version. Fixes thesofproject#842 Signed-off-by: Marc Herbert <[email protected]>
marc-hb
changed the title
|
https://sof-ci.01.org/softestpr/PR860/build981/devicetest/?model=WHL_UPEXT_HDA_ZEPHYR&testcase=check-pause-resume-capture-10 is unrelated thesofproject/sof/issues/5352 One UP2 was not available. Everything else passed and the logs looks as expected. |
plbossart
approved these changes
Feb 16, 2022
aiChaoSONG
approved these changes
Feb 16, 2022
keqiaozhang
approved these changes
Feb 16, 2022
|
Forgot to update the error message, fixed in #861 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Fixes #842 and #845. Follows the direction discussed and agreed at the bottom of superseded #855
Thanks to the addition of KERNEL_CHECKPOINT logic, also fixes bug where a very old firmware load was enough to make
check-kmod-load-unload.shpass.