-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-case: manual: Simple probes functionality test #923
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks @jsarha . I think this is really useful to document the test process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good and thank you for the update.
Almost ready to merge, good clarity for manual test note. When you update it please make it normal PR.
c43759a
to
8a791ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsarha Are those configurations in this document all supported by thesofproject/sof and thesofproject/linux? So I can try manually.
Yes, they are. Also the both PRs fixing the problems related to this are now merged. I wrote the test descriptions based on how I got the feature working last week, so I think it should be good. |
The form looks great but I'm ignorant about the content. @jsarha could you get a couple more reviewers? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsarha, great to have something for the probes!
I have couple candidates for clarification, if you think they stand.
8a791ed
to
9dcf2d6
Compare
CONFIG_PROBE_POINTS_MAX=16 | ||
CONFIG_PROBE_DMA_MAX=4 | ||
|
||
In fact PROBE_DMA_MAX is ignored as inection is not currently supported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/inection/injection
Why mention CONFIG_PROBE_DMA_MAX in the first place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If CONFIG_PROBE is enabled through menuconfig the CONFIG_PROBE_DMA_MAX option appears with the default value of 4, so I think it causes less confusion to mention it than leaving it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it comes with 0 as default, but never checked the kconfig file to be honest..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you have put the zero there. If enabled for the first time (I think I had not touched the items before), the two numeric options appear as above.
Signed-off-by: Jyri Sarha <[email protected]>
9dcf2d6
to
256272a
Compare
Signed-off-by: Jyri Sarha [email protected]
This is very simple and fast put together test for probe capture functionality.