Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configs: add ipc4 override config for tgl #5227

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

aiChaoSONG
Copy link
Collaborator

@aiChaoSONG aiChaoSONG commented Jan 19, 2022

The override config can be used to build tgl
and tgl-h firmware with IPC4 configuration.

Signed-off-by: Chao Song [email protected]

@aiChaoSONG aiChaoSONG requested a review from marc-hb as a code owner January 19, 2022 08:56
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a generic -o option, can we use it instead? We should stop duplicating Kconfig into a shell script, it's messy and does not scale. See how the kernel does it: https://github.com/thesofproject/kconfig

Then we have to duplicate these options in yet another CI interface layer on top. Instead we need the ability to input any kconfig configuration to CI or anything: completely flexible and generic with no options duplicated in multiple layers to maintain.

EDIT:

The override config can be used to build tgl
and tgl-h firmware with IPC4 configuration.

Signed-off-by: Chao Song <[email protected]>
@aiChaoSONG aiChaoSONG changed the title xtensa-build-all: add an option to build with IPC4 configs: add ipc4 override config for tgl Jan 20, 2022
@aiChaoSONG aiChaoSONG requested a review from RanderWang January 20, 2022 02:55
Copy link
Collaborator

@RanderWang RanderWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgirdwood
Copy link
Member

Whats the use case ? I assume its to build for CI tests as this should also enable Zephyr.

@aiChaoSONG
Copy link
Collaborator Author

@lgirdwood It is used to build tigerlake firmware with IPC4 for CI and developers. sof+zephyr+ipc4 has build failure now, once it is fixed, it will be added in CI, too.

@lgirdwood
Copy link
Member

@kkarask @wszypelt @mwasko - we can use the config for CI IPC4 mode.

@lgirdwood lgirdwood merged commit daf985b into thesofproject:main Jan 21, 2022
@plbossart
Copy link
Member

@aiChaoSONG @lgirdwood we need to have a different file name for the result, e.g. sof-tgl.ri4 or sof-tgl.bin4. this needs to be different from sof-tgl.ri, which will lead to confusions and support issues.

@lgirdwood
Copy link
Member

@marc-hb are you able to update the appropriate CMakefile to use the ri4 file extension for IPC4 binaries (and topologies later) as I think @aiChaoSONG is off now for CNY

@marc-hb
Copy link
Collaborator

marc-hb commented Jan 25, 2022

If this is top priority then yes I can. Thanks @ranj063 for @plbossart for providing some context. I need more, let's have a chat.

@marc-hb
Copy link
Collaborator

marc-hb commented Jan 29, 2022

I expressed consistency concerns with .ri4: it would break *.ri scripts when the exact same rimage tool(s) are still used.

The current proposal seems to be sof-tgl-ipc4.ri

A (slightly) better place where this is being discussed too: thesofproject/sof-test#841

@marc-hb
Copy link
Collaborator

marc-hb commented Feb 9, 2022

There is already a generic -o option, can we use it instead? We should stop duplicating Kconfig into a shell script, it's messy and does not scale.

I was wrong, apologies. Now that I know more about IPC4, I realize it's nothing like the usual Kconfig and deserves "top-level" interfaces. I will work on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants