-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configs: add ipc4 override config for tgl #5227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a generic -o
option, can we use it instead? We should stop duplicating Kconfig into a shell script, it's messy and does not scale. See how the kernel does it: https://github.com/thesofproject/kconfig
Then we have to duplicate these options in yet another CI interface layer on top. Instead we need the ability to input any kconfig configuration to CI or anything: completely flexible and generic with no options duplicated in multiple layers to maintain.
EDIT:
d7019fe
to
4334a62
Compare
The override config can be used to build tgl and tgl-h firmware with IPC4 configuration. Signed-off-by: Chao Song <[email protected]>
4334a62
to
559ea40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Whats the use case ? I assume its to build for CI tests as this should also enable Zephyr. |
@lgirdwood It is used to build tigerlake firmware with IPC4 for CI and developers. sof+zephyr+ipc4 has build failure now, once it is fixed, it will be added in CI, too. |
@aiChaoSONG @lgirdwood we need to have a different file name for the result, e.g. sof-tgl.ri4 or sof-tgl.bin4. this needs to be different from sof-tgl.ri, which will lead to confusions and support issues. |
@marc-hb are you able to update the appropriate CMakefile to use the |
If this is top priority then yes I can. Thanks @ranj063 for @plbossart for providing some context. I need more, let's have a chat. |
I expressed consistency concerns with The current proposal seems to be A (slightly) better place where this is being discussed too: thesofproject/sof-test#841 |
I was wrong, apologies. Now that I know more about IPC4, I realize it's nothing like the usual Kconfig and deserves "top-level" interfaces. I will work on that. |
The override config can be used to build tgl
and tgl-h firmware with IPC4 configuration.
Signed-off-by: Chao Song [email protected]