xtensa-build-zephyr.py: drop check=True, now the default #5706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 475e09f ("xtensa-build-zephyr.py: default to subprocess.run(check=True)") switched the default value of the execute_command() function to "True". Remove all the "check=True" arguments that are now redundant. Zero functional change. Signed-off-by: Marc Herbert <[email protected]>
|
Can one of the admins verify this patch? |
|
https://sof-ci.01.org/sofpr/PR5706/build48/devicetest/?model=CML_RVP_SDW_ZEPHYR&testcase=multiple-pipeline-capture is known issue #5352 https://sof-ci.01.org/sofpr/PR5706/build48/devicetest/?model=WHL_UPEXT_HDA_ZEPHYR&testcase=check-suspend-resume-with-capture-5 is the usual rtcwake timeout Quickbuild has been down for more than a week (PTS-38280) None of the errors are possibly related to this pure build script change. |
|
@marc-hb @lgirdwood CI QB build and tests green |
lgirdwood
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 475e09f ("xtensa-build-zephyr.py: default to
subprocess.run(check=True)") switched the default value of the
execute_command() function to "True". Remove all the "check=True"
arguments that are now redundant.
Zero functional change.
Signed-off-by: Marc Herbert [email protected]