-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using AutoLayout for progressView since [UIScreen mainScreen].bounds … #224
Open
jackie-li
wants to merge
53
commits into
thiagoperes:master
Choose a base branch
from
jackie-li:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is orientation-dependent in iOS8
…placed progress view when orientations do not match Progress view is misplaced when the device is in landscape orientation, but application does not support it.
…splaced-when-app-is-portrait-only Use actual interface orientation instead of the device one
…ion_button_image Enable customize action button image
…at double tap zoom out never works in some cases.
Expose label so it can be used by subclasses setupCaption.
…lure Add custom image failure response
fix code style, fix using old method for downloadImageWithURL:
Typo fix in Readme
Fix using SDWebImageManager
Done button margin and size
Improve support for subclassing IDMCaptionView
Fix the animation of double tap zoom out when minScale > 1
…_fix Fix caption position bug
…tion_fix Fix incorrect done button position
Fix a typo in dutch translations
'SDWebImage', '4.0.0' -> 'SDWebImage', '4.1.0' In new version fixed some crashes.
Add privacy access request
Safe areas are calculated for toolbar, done button and photo frame. This accounts for orientation and fall back for pre-iOS 11 devices.
chore: drag & drop photo
iPhone X Support
add turkish localization
Update IDMPhotoBrowser.podspec
Support Smart Invert mode in iOS11
kiancheong
added a commit
to kiancheong/IDMPhotoBrowser
that referenced
this pull request
Aug 27, 2018
# Conflicts: # Classes/IDMZoomingScrollView.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The position of progressView in IDMZoomingScrollView is incorrect when running on a landscape device.
Since iOS 8, [UIScreen mainScreen].bounds is orientation-dependent.
Using AutoLayout to fix this issue.
Reference:http://stackoverflow.com/questions/24150359/is-uiscreen-mainscreen-bounds-size-becoming-orientation-dependent-in-ios8