-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #117: add localtime to stop_date where clause #118
Conversation
Quality Gate passedIssues Measures |
Thanks for the PR, lgtm, not tested though (see comments in #117) |
Setting the TZ environment variable using Next steps:
|
Forgot the other detail from my conversation with @mikez last week, which was that we think the call to So for example if I call the following... ...and it's currently 3:55pm, it only goes back The last few lines of
So In this context of this PR, this means I can't create a reliable test that will cover the change I made to |
The decision to be made here, I think, is:
Thoughts? @mikez @AlexanderWillner |
👍 I vote for splitting this into two PRs. As for the behavior of "last", maybe @lmgibson can help us here as he was the architect here. In essence, the question is whether |
@mikez Marked as Ready for Review per your approval. @AlexanderWillner I believe this is over to you now (unless you disagree).
|
@chrisgurney I ran the tests. There seem to be some doctest failures still. You can run these with |
Update: I also needed to install ...otherwise I was getting errors running
|
@mikez Back to you. |
@AlexanderWillner If you'd enjoy to do so, can you add a check for |
@chrisgurney |
Here's what I was thinking:
|
You can do multiple arguments to pip: |
@mikez Linting issues fixed. Thanks for the tips. |
@chrisgurney 🥳🙌 |
Everything passed! For the future I think it would also be helpful to add a CONTRIBUTING file to the project that includes:
|
@chrisgurney Good idea! Do you want to craft such a simple file? |
Thought you might suggest that. 😅 Perhaps when I come back to the second test, once (if) |
@chrisgurney I think you're almost there. If you give #118 (comment) as an input to some GPT, I'm sure it can make a Contributing.md for you. :) |
@mikez I've got a draft of CONTRIBUTING.md almost ready. I'll submit a PR soon. |
Fix for #117, by adding "localtime" to the
stop_date
where clause.